Delta Between Two Patch Sets: includes/layout/header.tmpl
Issue 29485575:
Issue 5385 - Create Site Header Component for Help Center (Closed)
Left Patch Set: Implement navbar-collapse
Created Aug. 25, 2017, 8:25 a.m.
Right Patch Set: Include site variables before website-defaults
Created Sept. 1, 2017, 12:11 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
static/img/png/external-icon.png » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <header id="site-header" class="navbar"> | 1 <header id="site-header" class="navbar"> |
| 2 <div class="navbar-wrapper"> | 2 <div class="navbar-wrapper"> |
| 3 <h1 id="site-title"> | 3 <h1 id="site-title"> |
| 4 {{ "index" | linkify() }} | 4 {{ "index" | linkify() }} |
| 5 <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt ="{{ "eyeo Help" | translate("site-title", "Image alt text") }}"> | 5 <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt ="{{ "eyeo Help" | translate("site-title", "Image alt text") }}"> |
| 6 </a> | 6 </a> |
| 7 </h1> | 7 </h1> |
| 8 | 8 |
| 9 <button class="toggle-navbar-collapse unstyled tablet-and-mobile-only"> | 9 <button class="toggle-navbar-collapse unstyled phablet-and-mobile-only"> |
| 10 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" a lt="{{ "Toggle Search Bar" | translate("search-toggle-alt", "Image alt text") }} "> | 10 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" a lt="{{ "Toggle Search Bar" | translate("search-toggle-alt", "Image alt text") }} "> |
| 11 </button> | 11 </button> |
| 12 | 12 |
| 13 <div class="navbar-collapse"> | 13 <div class="navbar-collapse"> |
| 14 <form id="search-form" action="https://duckduckgo.com" method="GET"> | 14 <form id="search-form" action="https://duckduckgo.com" method="GET"> |
| 15 <label for="search" class="sr-only">{{ "Search Adblock Plus Help" | tran slate("search-form-label", "Input label") }}</label> | 15 <label for="search" class="sr-only">{{ "Search Adblock Plus Help" | tran slate("search-form-label", "Input label") }}</label> |
| 16 <input id="search" name="q" type="search" placeholder="{{ "Search Adbloc k Plus Help" | translate("search-form-label", "Input label") }}"> | 16 <input id="search" name="q" type="search" placeholder="{{ "Search Adbloc k Plus Help" | translate("search-form-label", "Input label") }}"> |
| 17 <input type="hidden" name="sites" value="adblockplus.org"> | 17 <input type="hidden" name="sites" value="adblockplus.org"> |
| 18 <button type="submit"> | 18 <button type="submit"> |
| 19 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2 x" alt="{{ "Search" | translate("search-icon-alt", "Image alt text") }}"> | 19 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2 x" alt="{{ "Search" | translate("search-icon-alt", "Image alt text") }}"> |
| 20 </button> | 20 </button> |
| 21 </form> | 21 </form> |
| 22 | 22 |
| 23 <nav id="product-website-link"> | 23 <nav id="product-website-link"> |
| 24 <a href="https://adblockplus.org/"> | 24 <a href="https://adblockplus.org/"> |
|
juliandoucette
2017/08/29 16:17:28
NIT: You can't see the text-decoration under the i
ire
2017/09/01 10:57:20
Done. Removed the empty space between the text and
| |
| 25 {{ "Adblock Plus" | translate("abp-product-link", "Link label") }} | 25 {{ "Adblock Plus" | translate("abp-product-link", "Link label") }}<img src="/img/png/external-icon.png" srcset="/img/svg/external-icon.svg 2x" alt="{{ "External link icon" | translate("external-link-icon", "Image alt text") }}"> |
| 26 <img src="/img/png/external-icon.png" srcset="/img/svg/external-icon.s vg 2x" alt="{{ "External link icon" | translate("external-link-icon", "Image alt text") }}"> | |
| 27 </a> | 26 </a> |
| 28 </nav> | 27 </nav> |
| 29 </div> | 28 </div> |
| 30 </div> | 29 </div> |
| 31 </header> | 30 </header> |
| LEFT | RIGHT |
« no previous file
|
static/img/png/external-icon.png » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
