Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/layout/_header.scss

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)
Left Patch Set: Implement navbar-collapse Created Aug. 25, 2017, 8:25 a.m.
Right Patch Set: Include site variables before website-defaults Created Sept. 1, 2017, 12:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/components/_search-form.scss ('k') | static/scss/layout/_navbar.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 #site-header 17 #site-header
18 { 18 {
19 min-height: $site-header-height; 19 min-height: $site-header-height;
20 font-size: $small-font; 20 font-size: $small-font;
21 line-height: $site-header-content-line-height; 21 line-height: $site-header-content-line-height;
22 } 22 }
23 23
24 #site-title 24 #site-title
25 { 25 {
26 float: left; 26 float: left;
27 margin-right: $xl; 27 margin-right: $xl;
28 } 28 }
29 29
30 html[dir="rtl"] #site-title
31 {
32 float: right;
33 margin-right: 0;
34 margin-left: $xl;
35 }
36
30 #site-title img 37 #site-title img
31 { 38 {
32 height: $lg - 5px; 39 height: $lg;
juliandoucette 2017/08/29 16:17:31 NIT: It seem strange to shrink the logo and not th
ire 2017/09/01 10:57:23 You're right. I've kept the logo the same size. Di
33 vertical-align: middle; 40 vertical-align: middle;
34
35 @media (min-width: $tablet-breakpoint)
36 {
37 height: $lg;
38 }
39 } 41 }
40 42
41 .toggle-navbar-collapse 43 .toggle-navbar-collapse
42 { 44 {
43 width: $site-header-content-line-height; 45 width: $site-header-content-line-height;
44 float: right; 46 float: right;
45 line-height: $site-header-content-line-height; 47 line-height: $site-header-content-line-height;
46 text-align: right; 48 text-align: right;
47 cursor: pointer; 49 cursor: pointer;
48 50
49 img 51 img
50 { 52 {
51 width: $md; 53 width: $md;
52 vertical-align: middle; 54 vertical-align: middle;
53 } 55 }
54 } 56 }
55 57
56 html[dir="rtl"] 58 html[dir="rtl"] .toggle-navbar-collapse
57 { 59 {
58 #site-title 60 float: left;
juliandoucette 2017/08/29 16:17:32 NIT: Move rtl #site-title above .toggle-navbar-col
ire 2017/09/01 10:57:24 Done.
59 {
60 float: right;
61 margin-right: 0;
62 margin-left: $xl;
63 }
64
65 .toggle-navbar-collapse
66 {
67 float: left;
68 }
69 } 61 }
70 62
71 .no-js .toggle-navbar-collapse 63 .no-js .toggle-navbar-collapse
72 { 64 {
73 display: none; 65 display: none;
74 } 66 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld