Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/layout/_navbar.scss

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)
Patch Set: Fix alignment of search form, reformat JS Created Aug. 22, 2017, 12:14 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/layout/_navbar.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/scss/layout/_navbar.scss
@@ -0,0 +1,38 @@
+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
+
+.navbar
+{
+ padding-top: $md;
+ padding-bottom: $md;
+ color: $white;
juliandoucette 2017/08/23 14:39:09 I don't think `.navbar` should have color because
ire 2017/08/25 08:27:13 I agree with you that "navbar" is more a descripti
juliandoucette 2017/08/29 16:17:27 I think you have the right idea. If we don't add c
ire 2017/09/01 10:57:20 I think this is a good idea we can implement when
+ background-color: $black;
+}
+
+.navbar a
juliandoucette 2017/08/23 14:39:09 See comment above.
ire 2017/08/25 08:27:12 Acknowledged.
+{
+ color: $white;
+}
+
+.navbar-wrapper
juliandoucette 2017/08/23 14:39:09 See comment [here](https://codereview.adblockplus.
ire 2017/08/25 08:27:13 Acknowledged.
+{
+ width: $navbar-width;
+ max-width: 100%;
+ margin-right: auto;
+ margin-left: auto;
+ padding-right: $md;
+ padding-left: $md;
+}

Powered by Google App Engine
This is Rietveld