Issue 5406 - Create Site Footer Component for Help Center

static/scss/layout/_footer.scss

+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+#site-footer
+{
+  font-size: $small-font;
+}
+
+#site-footer .one-fourth
+{
+  margin-bottom: $sm;
+
+  @media (min-width: $phablet-breakpoint)
+  {
+    margin-bottom: 0;
+  }
+}
+
+#site-footer .three-fourths

[juliandoucette, 2017/09/06 17:48:22]

NIT: This seems too general. We could conceivably add another row with
three-fourths before one-fourth. For that reason, I would be more specific e.g.
#site-footer-nav or .align-right.

[ire, 2017/09/08 09:53:36]

Done.

+{
+  @media (min-width: $phablet-breakpoint)
+  {
+    text-align: right;
+  }
+}
+
+[dir="rtl"] #site-footer .three-fourths
+{
+  @media (min-width: $phablet-breakpoint)
+  {
+    text-align: left;
+  }
+}
+
+#site-footer-nav
+{
+  @media (min-width: $tablet-breakpoint)
+  {
+    display: inline;
+  }
+}
+
+#site-footer-nav ul

[juliandoucette, 2017/09/06 17:48:22]

NIT: Shouldn't we do this with a horizontal list utility class?

[ire, 2017/09/08 09:53:36]

Done.

+{
+  display: inline;
+  list-style: none;
+}
+
+[dir="rtl"] #site-footer-nav ul
+{
+  padding: 0;
+}
+
+#site-footer-nav li
+{
+  display: inline;
+  margin-right: $sm;
+  padding-right: $sm;
+  border-right: 1px solid $gray;

[juliandoucette, 2017/09/06 17:48:22]

NIT: Why not border-right the first-child or border-left the last-child instead
of border-righting everyone and unborder-righting the last-child?

The same logic may apply to spacing.

[ire, 2017/09/08 09:53:36]

I did it this way because if we added another list item, we would want there to
be a border-right and margin on all items besides the last child. What you are
suggesting will work well now, but not if we added another item.

[juliandoucette, 2017/09/08 17:02:52]

Good point.

+
+  &:last-child
+  {
+    margin-right: 0px;
+    padding-right: 0px;
+    border-right: 0px;
+  }
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    &:last-child
+    {
+      margin-right: $sm;
+      padding-right: $sm;
+      border-right: 1px solid $gray;
+    }
+  }
+}