Issue 5406 - Create Site Footer Component for Help Center

static/scss/layout/_grid.scss

+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+.column
+{
+  padding: 0;

[juliandoucette, 2017/09/06 17:48:22]

Why eliminate the gutter width?

Note: You didn't overwrite the negative margin on .row :S

[ire, 2017/09/08 09:53:36]

In the case of the footer, the gutter isn't needed and causes the content to not
be aligned with the header. But I should have just restricted this to *only* in
the footer, which I've done now.

[juliandoucette, 2017/09/08 17:02:53]

I agree. But this does beg the question of why you chose to use the grid in the
footer (which I don't yet have an opinion about). 

[ire, 2017/09/12 08:57:53]

Most of the other styles are still valid. I didn't think it necessary to rewrite
most of the grid styles only to override the one style

+}
+
+@media(min-width: $phablet-breakpoint)

[juliandoucette, 2017/09/06 17:48:22]

Note: It seems like we could make sizes conditional (in addition to
configurable) in website-defaults. I think this is a good idea.

[ire, 2017/09/08 09:53:36]

How would that work? In this case, the sizes themselves aren't being changed,
it's the breakpoints. 

[juliandoucette, 2017/09/08 17:02:53]

Good question. Conditionals aren't quite the way to go it seems. I suggest
something like this:

https://codereview.adblockplus.org/29539827

[ire, 2017/09/12 08:57:53]

Thanks!

I would like to update website-defaults in a separate issue/noissue since it
will change more than just this (adds the reset, changes the $mobile variable
name to $phone, etc). So if you don't mind, I will update this part after this
has been committed. 

+{
+  .one-half,
+  .one-third,
+  .two-thirds,
+  .one-fourth,
+  .three-fourths
+  {
+    width: 50%;
+  }
+}
+
+@media(min-width: $tablet-breakpoint)
+{
+  .one-third
+  {
+    width: 33.333333%;
+  }
+
+  .two-thirds
+  {
+    width: 66.666667%;
+  }
+
+  .one-fourth
+  {
+    width: 25%;
+  }
+
+  .three-fourths
+  {
+    width: 75%;
+  }
+}