Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/layout/_footer.scss

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)
Left Patch Set: Rebase Created Aug. 11, 2017, 4:08 p.m.
Right Patch Set: Remove langnames commit, use website-default breakpoint variables Created Sept. 18, 2017, 3:09 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 #site-footer 17 #site-footer
18 { 18 {
19 font-size: $small-font; 19 font-size: $small-font;
juliandoucette 2017/08/22 14:33:43 I don't think this does anything after all other s
ire 2017/09/04 20:28:08 Which other styles? From my test, this makes a dif
juliandoucette 2017/09/06 17:48:20 I was mislead by the effect of font-size: 100%; so
ire 2017/09/08 09:53:33 No worries :)
20 } 20 }
21 21
22 #site-footer .one-fourth 22 #site-footer .column
juliandoucette 2017/08/22 14:33:43 I think it makes more sense to add margin (in em n
ire 2017/09/04 20:28:08 The margin is more to separate the first row from
23 { 23 {
24 margin-bottom: 10px; 24 padding: 0px;
25 25
26 @media (min-width: $mobile-breakpoint) 26 @media (min-width: $phablet-breakpoint)
27 {
28 width: 50%;
29 }
30 }
31
32 #site-footer-locales
33 {
34 margin-bottom: $sm;
35
36 @media (min-width: $phablet-breakpoint)
27 { 37 {
28 margin-bottom: 0; 38 margin-bottom: 0;
29 } 39 }
30 } 40 }
31 41
32 #site-footer .three-fourths 42 #site-footer-nav
33 { 43 {
34 @media (min-width: $mobile-breakpoint) 44 @media (min-width: $phablet-breakpoint)
35 { 45 {
36 text-align: right; 46 text-align: right;
37 } 47 }
38 } 48 }
39 49
40 #site-footer-nav 50 [dir="rtl"] #site-footer-nav
51 {
52 @media (min-width: $phablet-breakpoint)
53 {
54 text-align: left;
55 }
56 }
57
58 #site-footer-nav nav
41 { 59 {
42 @media (min-width: $tablet-breakpoint) 60 @media (min-width: $tablet-breakpoint)
43 { 61 {
44 display: inline; 62 display: inline;
45 } 63 }
46 } 64 }
47 65
48 #site-footer-nav ul 66 #site-footer-nav nav li
49 { 67 {
50 display: inline; 68 margin-right: $sm;
51 list-style: none; 69 padding-right: $sm;
52 } 70 border-right: 1px solid $gray;
53 71
54 #site-footer-nav li 72 &:last-child
55 {
56 display: inline;
57
58 &:not(:last-child)
juliandoucette 2017/08/22 14:33:43 not is not supported by IE
ire 2017/09/04 20:28:08 Done.
59 { 73 {
60 margin-right: 10px; 74 margin-right: 0px;
61 padding-right: 10px; 75 padding-right: 0px;
62 border-right: 1px solid $gray; 76 border-right: 0px;
63 } 77 }
64 78
65 @media (min-width: $tablet-breakpoint) 79 @media (min-width: $tablet-breakpoint)
66 { 80 {
67 &:last-child 81 &:last-child
juliandoucette 2017/08/22 14:33:43 last-child is not supported by IE
ire 2017/09/04 20:28:08 :last-child is supported by IE 9+ (http://caniuse.
juliandoucette 2017/09/06 17:48:20 I suggest that we support IE 8 by default or docum
ire 2017/09/08 09:53:33 The current browserlist for this site supports IE9
68 { 82 {
69 margin-right: 10px; 83 margin-right: $sm;
70 padding-right: 10px; 84 padding-right: $sm;
71 border-right: 1px solid $gray; 85 border-right: 1px solid $gray;
72 } 86 }
73 } 87 }
74 } 88 }
75 89
76 [dir="rtl"] 90 #site-footer-nav a
juliandoucette 2017/08/22 14:33:43 NIT: Please move rtl styles directly below ltr sty
ire 2017/09/04 20:28:08 Done.
77 { 91 {
78 #site-footer .three-fourths 92 white-space: nowrap;
79 {
80 @media (min-width: $mobile-breakpoint)
81 {
82 text-align: left;
83 }
84 }
85
86 #site-footer-nav ul
87 {
88 padding: 0;
89 }
90 } 93 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld