Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/layout/_grid.scss

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)
Left Patch Set: Rebased and updated Created Sept. 4, 2017, 8:27 p.m.
Right Patch Set: Remove langnames commit, use website-default breakpoint variables Created Sept. 18, 2017, 3:09 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/layout/_footer.scss ('k') | static/scss/main.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 .column 17 $half-breakpoint: $phablet-breakpoint;
ire 2017/09/18 15:13:12 I had to put these here because I couldn't use web
18 { 18 $third-breakpoint: $tablet-breakpoint;
19 padding: 0; 19 $fourth-breakpoint: $tablet-breakpoint;
juliandoucette 2017/09/06 17:48:22 Why eliminate the gutter width? Note: You didn't
ire 2017/09/08 09:53:36 In the case of the footer, the gutter isn't needed
juliandoucette 2017/09/08 17:02:53 I agree. But this does beg the question of why you
ire 2017/09/12 08:57:53 Most of the other styles are still valid. I didn't
20 }
21
22 @media(min-width: $phablet-breakpoint)
juliandoucette 2017/09/06 17:48:22 Note: It seems like we could make sizes conditiona
ire 2017/09/08 09:53:36 How would that work? In this case, the sizes thems
juliandoucette 2017/09/08 17:02:53 Good question. Conditionals aren't quite the way t
ire 2017/09/12 08:57:53 Thanks! I would like to update website-defaults i
23 {
24 .one-half,
25 .one-third,
26 .two-thirds,
27 .one-fourth,
28 .three-fourths
29 {
30 width: 50%;
31 }
32 }
33
34 @media(min-width: $tablet-breakpoint)
35 {
36 .one-third
37 {
38 width: 33.333333%;
39 }
40
41 .two-thirds
42 {
43 width: 66.666667%;
44 }
45
46 .one-fourth
47 {
48 width: 25%;
49 }
50
51 .three-fourths
52 {
53 width: 75%;
54 }
55 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld