Unified Diff: includes/layout/footer.tmpl
Issue 29488555:
Issue 5406 - Create Site Footer Component for Help Center (Closed)
Patch Set: Use menu pattern on custom select, horizontal list utliity class, etc
Created Sept. 8, 2017, 9:52 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
settings.ini » ('j')
|
static/scss/components/_select.scss » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: includes/layout/footer.tmpl |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/includes/layout/footer.tmpl |
| @@ -0,0 +1,31 @@ |
| +<footer id="site-footer" class="navbar"> |
| + <div class="navbar-wrapper row"> |
| + <div id="site-footer-locales" class="column one-fourth"> |
| + <div class="custom-select"> |
| + <button class="custom-select-selected" aria-expanded="false" aria-haspopup="true"> |
| + {{ config.get("langnames", locale) }} |
| + </button> |
| + <ul class="custom-select-options" aria-label="{{ "Select Language" | translate("language-options-label", "Label") }}" role="menu" tabindex="-1"> |
| + {% for lang in available_locales %} |
| + <li role="none"> |
|
juliandoucette
2017/09/08 17:02:53
Shouldn't this role be "presentation"? :/
ire
2017/09/12 08:57:55
According to the example, it should be "none" in o
juliandoucette
2017/09/12 11:41:12
Acknowledged.
I looked into this further and forg
|
| + {{ page | linkify(lang) }} |
| + {{ config.get("langnames", lang) }} |
| + </a> |
| + </li> |
| + {% endfor %} |
| + </ul> |
| + </div> |
| + </div> |
| + <div id="site-footer-nav" class="column three-fourths"> |
|
juliandoucette
2017/09/08 17:02:53
This section is aligned left between phablet and t
juliandoucette
2017/09/08 17:02:54
The nav and small are not vertically aligned middl
ire
2017/09/12 08:57:54
I wasn't intended for it to. The content in both a
ire
2017/09/12 08:57:54
I wasn't able to replicate this, but the .custom-s
|
| + <nav> |
| + <ul class="horizontal-list"> |
| + <li><a href="">{{ "Legal" | translate("footer-nav-link-1", "Navigation link") }}</a></li> |
| + <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" | translate("footer-nav-link-2", "Navigation link") }}</a></li> |
| + </ul> |
| + </nav> |
| + <small class="muted"> |
|
juliandoucette
2017/09/08 17:02:54
"eyeo GmbH" breaks oddly between phablet and table
ire
2017/09/12 08:57:54
Done.
|
| + {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" | translate("footer-trademark-notice", "Paragraph") }} |
| + </small> |
| + </div> |
| + </div> |
| +</footer> |
« no previous file with comments
|
« no previous file
|
settings.ini » ('j')
|
static/scss/components/_select.scss » ('J')
