Issue 5384 - Introduced dedicated mobile options page

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 179 matching lines @@
   });
 
   port.on("app.listen", (message, sender) =>
   {
     getListenerFilters(sender.page).app = message.filter;
   });
 
   port.on("app.open", (message, sender) =>
   {
     if (message.what == "options")
-      ext.showOptions();
+    {

[saroyanm, 2017/07/18 12:46:26]

Why is this change necessary ?

[Thomas Greiner, 2017/07/18 17:42:30]

This is how we pass the domain to the options page when opening it.

+      ext.showOptions(() =>
+      {
+        if (!message.action)
+          return;
+
+        sendMessage("app", message.action, ...message.args);
+      });
+    }
   });
 
   port.on("filters.add", (message, sender) =>
   {
     let result = require("filterValidation").parseFilter(message.text);
     let errors = [];
     if (result.error)
       errors.push(result.error.toString());
     else if (result.filter)
       FilterStorage.addFilter(result.filter);
@@ skipping 213 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);