Side by Side Diff: README.md
Issue 29488575:
Issue 5384 - Introduced dedicated mobile options page (Closed)
Patch Set: Addressed mobile-options.js comments
Created July 18, 2017, 5:39 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
background.js » ('j')
|
mobile-options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 Shared Adblock Plus UI code | 1 Shared Adblock Plus UI code |
| 2 =========================== | 2 =========================== |
| 3 | 3 |
| 4 The user interface elements defined in this repository will be used by various | 4 The user interface elements defined in this repository will be used by various |
| 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be | 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be |
| 6 tested within this repository, even though they might not work exactly the same | 6 tested within this repository, even though they might not work exactly the same |
| 7 as they will do in the final product. | 7 as they will do in the final product. |
| 8 | 8 |
| 9 Directory structure | 9 Directory structure |
| 10 ------------------- | 10 ------------------- |
| (...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 63 To aid testing, the behavior of this page is affected by a number of URL | 63 To aid testing, the behavior of this page is affected by a number of URL |
| 64 parameters: | 64 parameters: |
| 65 | 65 |
| 66 * `platform`, `platformVersion`, `application`, `applicationVersion`: sets | 66 * `platform`, `platformVersion`, `application`, `applicationVersion`: sets |
| 67 application parameters that are normally determined by Adblock Plus. | 67 application parameters that are normally determined by Adblock Plus. |
| 68 * `filterlistsReinitialized`: setting these parameters to `true` should | 68 * `filterlistsReinitialized`: setting these parameters to `true` should |
| 69 trigger warnings referring to issues detected by Adblock Plus. | 69 trigger warnings referring to issues detected by Adblock Plus. |
| 70 * `blockedURLs`: a comma-separated list of URLs that should be considered | 70 * `blockedURLs`: a comma-separated list of URLs that should be considered |
| 71 blocked (necessary to test the check for blocked scripts in sharing buttons). | 71 blocked (necessary to test the check for blocked scripts in sharing buttons). |
| 72 | 72 |
| 73 mobile-options.html | |
| 74 ------------ | |
| 75 | |
| 76 This is a web extension implementation of the Adblock Plus for Firefox Mobile | |
| 77 options page. | |
| 78 | |
| 79 To aid testing, the behavior of this page is affected by a number of URL | |
| 80 parameters: | |
| 81 | |
| 82 * `addSubscription=true`: this parameter should trigger a dialog for adding | |
| 83 subscriptions as initiated by clicking on an "abp:subscribe" link | |
| 84 * `showPageOptions=true`: shows page-specific options | |
| 85 | |
| 73 new-options.html | 86 new-options.html |
| 74 ------------ | 87 ------------ |
| 75 | 88 |
| 76 This is the new implementation of the Adblock Plus options page which will be | 89 This is the new implementation of the Adblock Plus options page which will be |
| 77 the primary UI for changing settings and for managing filter lists. | 90 the primary UI for changing settings and for managing filter lists. |
| 78 | 91 |
| 79 To aid testing, the behavior of this page is affected by a number of URL | 92 To aid testing, the behavior of this page is affected by a number of URL |
| 80 parameters: | 93 parameters: |
| 81 | 94 |
| 82 * `addonVersion`: sets addon version application parameter that is used for | 95 * `addonVersion`: sets addon version application parameter that is used for |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 98 Linting | 111 Linting |
| 99 ------- | 112 ------- |
| 100 | 113 |
| 101 You can lint the code using [ESLint](http://eslint.org). | 114 You can lint the code using [ESLint](http://eslint.org). |
| 102 | 115 |
| 103 eslint *.js lib ext | 116 eslint *.js lib ext |
| 104 | 117 |
| 105 You will need to set up ESLint and our configuration first, see | 118 You will need to set up ESLint and our configuration first, see |
| 106 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | 119 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) |
| 107 for more information. | 120 for more information. |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
background.js » ('j')
|
mobile-options.js » ('J')
