Issue 5384 - Introduced dedicated mobile options page

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2017 eyeo GmbH
+ * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 15 matching lines @@
   const {FilterStorage} = require("filterStorage");
   const {FilterNotifier} = require("filterNotifier");
   const {defaultMatcher} = require("matcher");
   const {ElemHideEmulation} = require("elemHideEmulation");
   const {Notification: NotificationStorage} = require("notification");
 
   const {Filter, BlockingFilter, RegExpFilter} = require("filterClasses");
   const {Synchronizer} = require("synchronizer");
 
   const info = require("info");
-  const {Subscription,
-         DownloadableSubscription,
-         SpecialSubscription} = require("subscriptionClasses");
+  const {
+    Subscription,
+    DownloadableSubscription,
+    SpecialSubscription
+  } = require("subscriptionClasses");
 
   // Some modules doesn't exist on Firefox. Moreover,
   // require() throws an exception on Firefox in that case.
   // However, try/catch causes the whole function to to be
   // deoptimized on V8. So we wrap it into another function.
   function tryRequire(module)
   {
     try
     {
       return require(module);
@@ skipping 138 matching lines @@
   });
 
   port.on("app.listen", (message, sender) =>
   {
     getListenerFilters(sender.page).app = message.filter;
   });
 
   port.on("app.open", (message, sender) =>
   {
     if (message.what == "options")
     {

[saroyanm, 2017/07/18 12:46:26]

Why is this change necessary ?

[Thomas Greiner, 2017/07/18 17:42:30]

This is how we pass the domain to the options page when opening it.

       ext.showOptions(() =>
       {
         if (!message.action)
           return;
 
         sendMessage("app", message.action, ...message.args);
       });
     }
   });
 
@@ skipping 18 matching lines @@
     return filter instanceof BlockingFilter;
   });
 
   port.on("filters.get", (message, sender) =>
   {
     if (message.what == "elemhideemulation")
     {
       let filters = [];
       const {checkWhitelisted} = require("whitelisting");
 
-      if (Prefs.enabled && !checkWhitelisted(sender.page, sender.frame,
-                            RegExpFilter.typeMap.DOCUMENT |
-                            RegExpFilter.typeMap.ELEMHIDE))
+      let isWhitelisted = checkWhitelisted(sender.page, sender.frame,
+        RegExpFilter.typeMap.DOCUMENT | RegExpFilter.typeMap.ELEMHIDE);
+      if (Prefs.enabled && !isWhitelisted)
       {
         let {hostname} = sender.frame.url;
         filters = ElemHideEmulation.getRulesForDomain(hostname);
         filters = filters.map((filter) =>
         {
           return {
             selector: filter.selector,
             text: filter.text
           };
         });
@@ skipping 180 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);