Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: mobile-options.html

Issue 29488575: Issue 5384 - Introduced dedicated mobile options page (Closed)
Left Patch Set: Created July 13, 2017, 2:54 p.m.
Right Patch Set: Added ID constants Created Aug. 28, 2017, 2:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « messageResponder.js ('k') | mobile-options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2017 eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
11 - but WITHOUT ANY WARRANTY; without even the implied warranty of 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of
12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 - GNU General Public License for more details. 13 - GNU General Public License for more details.
14 - 14 -
(...skipping 14 matching lines...) Expand all
29 </head> 29 </head>
30 <body> 30 <body>
31 31
32 <main> 32 <main>
33 <h1 class="i18n_mops_title"></h1> 33 <h1 class="i18n_mops_title"></h1>
34 34
35 <p id="enabled-container" class="toggle-container" hidden> 35 <p id="enabled-container" class="toggle-container" hidden>
36 <span> 36 <span>
37 <label id="enabled-label" for="enabled"></label> 37 <label id="enabled-label" for="enabled"></label>
38 </span> 38 </span>
39 <input id="enabled" type="checkbox"> 39 <input id="enabled" type="checkbox" data-action="toggle-enabled">
40 <label class="toggle-image" for="enabled"></label> 40 <label class="toggle-image" for="enabled"></label>
saroyanm 2017/07/18 12:46:27 The toggle is invisible, Seems like the checkbox i
Thomas Greiner 2017/07/18 17:42:31 Not sure what you mean. I see the toggle using htt
saroyanm 2017/07/31 11:08:53 Interesting, the comment belongs to CSS file actua
saroyanm 2017/07/31 12:18:40 As discussed, this is my mistake, I didn't downloa
41 </p> 41 </p>
42 42
43 <h2 class="i18n_mops_subscriptions_header"></h2> 43 <h2 class="i18n_mops_subscriptions_header"></h2>
44 44
45 <ul id="subscriptions-installed"></ul> 45 <ul id="subscriptions-installed"></ul>
46 <button class="i18n_mops_filterlist_add" 46 <button class="i18n_mops_filterlist_add"
47 data-action="open-dialog" data-dialog="recommended"> 47 data-action="open-dialog" data-dialog="recommended">
48 </button> 48 </button>
49 49
50 <p class="toggle-container"> 50 <p class="toggle-container">
51 <span> 51 <span>
52 <label class="i18n_mops_acceptableAds_description checkbox" 52 <label class="i18n_mops_acceptableAds_description checkbox"
53 for="acceptableAds"> 53 for="acceptableAds">
54 </label> 54 </label>
55 <a id="acceptableAds-more" class="i18n_mops_acceptableAds_more"></a> 55 <a id="acceptableAds-more" class="i18n_mops_acceptableAds_more"></a>
56 </span> 56 </span>
57 <input id="acceptableAds" type="checkbox"> 57 <input id="acceptableAds" type="checkbox">
58 <label class="toggle-image" for="acceptableAds"></label> 58 <label class="toggle-image" for="acceptableAds"></label>
59 </p> 59 </p>
60 </main> 60 </main>
61 61
62 <div id="dialog" data-action="close-dialog"> 62 <div id="dialog" data-action="close-dialog">
63 <div id="dialog-recommended" role="dialog"> 63 <div id="dialog-recommended" role="dialog">
64 <ul id="subscriptions-recommended"></ul> 64 <ul id="subscriptions-recommended"></ul>
65 65
66 <menu> 66 <button class="i18n_mops_filterlist_add_url"
67 <button class="i18n_mops_filterlist_add_url" 67 data-action="open-dialog" data-dialog="subscribe">
68 data-action="open-dialog" data-dialog="subscribe"> 68 </button>
69 </button>
70 </menu>
71 </div> 69 </div>
72 70
73 <div id="dialog-subscribe" role="dialog"> 71 <div id="dialog-subscribe" role="dialog">
74 <form> 72 <form>
75 <h2 class="i18n_mops_subscribe_header"></h2> 73 <h2 class="i18n_mops_subscribe_header"></h2>
76 <p> 74 <p>
77 <input name="title" type="text"> 75 <input name="title" type="text">
78 <label class="i18n_mops_subscribe_title"></label> 76 <label class="i18n_mops_subscribe_title"></label>
79 <span class="i18n_mops_error_title error" data-error="title"></span> 77 <span class="i18n_mops_error_title error" data-error="title"></span>
80 </p> 78 </p>
(...skipping 10 matching lines...) Expand all
91 89
92 <button type="reset" class="i18n_mops_action_cancel secondary" 90 <button type="reset" class="i18n_mops_action_cancel secondary"
93 data-action="close-dialog"> 91 data-action="close-dialog">
94 </button> 92 </button>
95 </form> 93 </form>
96 </div> 94 </div>
97 </div> 95 </div>
98 96
99 </body> 97 </body>
100 </html> 98 </html>
LEFTRIGHT
« messageResponder.js ('k') | mobile-options.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld