mobile-options.html - Issue 29488575: Issue 5384 - Introduced dedicated mobile options page

Delta Between Two Patch Sets: mobile-options.html

Issue 29488575: Issue 5384 - Introduced dedicated mobile options page (Closed)

Left Patch Set: Created Aug. 1, 2017, 12:46 p.m.

Right Patch Set: Added ID constants Created Aug. 28, 2017, 2:51 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 - This file is part of Adblock Plus <https://adblockplus.org/>,	3 - This file is part of Adblock Plus <https://adblockplus.org/>,

4 - Copyright (C) 2006-2017 eyeo GmbH	4 - Copyright (C) 2006-present eyeo GmbH

5 -	5 -

6 - Adblock Plus is free software: you can redistribute it and/or modify	6 - Adblock Plus is free software: you can redistribute it and/or modify

7 - it under the terms of the GNU General Public License version 3 as	7 - it under the terms of the GNU General Public License version 3 as

8 - published by the Free Software Foundation.	8 - published by the Free Software Foundation.

9 -	9 -

10 - Adblock Plus is distributed in the hope that it will be useful,	10 - Adblock Plus is distributed in the hope that it will be useful,

11 - but WITHOUT ANY WARRANTY; without even the implied warranty of	11 - but WITHOUT ANY WARRANTY; without even the implied warranty of

12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 - GNU General Public License for more details.	13 - GNU General Public License for more details.

14 -	14 -

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 </span>	56 </span>

57 <input id="acceptableAds" type="checkbox">	57 <input id="acceptableAds" type="checkbox">

58 <label class="toggle-image" for="acceptableAds"></label>	58 <label class="toggle-image" for="acceptableAds"></label>

59 </p>	59 </p>

60 </main>	60 </main>

61	61

62 <div id="dialog" data-action="close-dialog">	62 <div id="dialog" data-action="close-dialog">

63 <div id="dialog-recommended" role="dialog">	63 <div id="dialog-recommended" role="dialog">

64 <ul id="subscriptions-recommended"></ul>	64 <ul id="subscriptions-recommended"></ul>

65	65

66 <menu>	66 <button class="i18n_mops_filterlist_add_url"

67 <button class="i18n_mops_filterlist_add_url"	67 data-action="open-dialog" data-dialog="subscribe">
saroyanm 2017/08/27 17:44:00 Button inside of menu has not been implemented yet Button inside of menu has not been implemented yet according to -> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu#Menu_button Thomas Greiner 2017/08/28 12:04:20 This is not what's mentioned in the link you refer Show quoted text On 2017/08/27 17:44:00, saroyanm wrote: > Button inside of menu has not been implemented yet according to -> > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu#Menu_button This is not what's mentioned in the link you refer to. It's about a dropdown button (i.e. "a button, which displays a menu when clicked") whereas here we have a button inside a menu. saroyanm 2017/08/28 12:27:19 Right, I found that link after this failed the HTM Show quoted text On 2017/08/28 12:04:20, Thomas Greiner wrote: > On 2017/08/27 17:44:00, saroyanm wrote: > > Button inside of menu has not been implemented yet according to -> > > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu#Menu_button > > This is not what's mentioned in the link you refer to. It's about a dropdown > button (i.e. "a button, which displays a menu when clicked") whereas here we > have a button inside a menu. Right, I found that link after this failed the HTML validation -> https://validator.w3.org But apparently the link was wrong. The error states: "Element button not allowed as child of element menu in this context" Thomas Greiner 2017/08/28 13:14:04 Ok, that makes sense. Sounds similar to putting `< Show quoted text On 2017/08/28 12:27:19, saroyanm wrote: > On 2017/08/28 12:04:20, Thomas Greiner wrote: > > On 2017/08/27 17:44:00, saroyanm wrote: > > > Button inside of menu has not been implemented yet according to -> > > > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu#Menu_button > > > > This is not what's mentioned in the link you refer to. It's about a dropdown > > button (i.e. "a button, which displays a menu when clicked") whereas here we > > have a button inside a menu. > > Right, I found that link after this failed the HTML validation -> > https://validator.w3.org But apparently the link was wrong. > > The error states: "Element button not allowed as child of element menu in this > context" Ok, that makes sense. Sounds similar to putting `<button>` into a `<ul>` element so I agree that we should avoid doing this. Done.
68 data-action="open-dialog" data-dialog="subscribe">	68 </button>

69 </button>

70 </menu>

71 </div>	69 </div>

72	70

73 <div id="dialog-subscribe" role="dialog">	71 <div id="dialog-subscribe" role="dialog">

74 <form>	72 <form>

75 <h2 class="i18n_mops_subscribe_header"></h2>	73 <h2 class="i18n_mops_subscribe_header"></h2>

76 <p>	74 <p>

77 <input name="title" type="text">	75 <input name="title" type="text">

78 <label class="i18n_mops_subscribe_title"></label>	76 <label class="i18n_mops_subscribe_title"></label>

79 <span class="i18n_mops_error_title error" data-error="title"></span>	77 <span class="i18n_mops_error_title error" data-error="title"></span>

80 </p>	78 </p>

(...skipping 10 matching lines...) Expand all Loading...
91	89

92 <button type="reset" class="i18n_mops_action_cancel secondary"	90 <button type="reset" class="i18n_mops_action_cancel secondary"

93 data-action="close-dialog">	91 data-action="close-dialog">

94 </button>	92 </button>

95 </form>	93 </form>

96 </div>	94 </div>

97 </div>	95 </div>

98	96

99 </body>	97 </body>

100 </html>	98 </html>

LEFT	RIGHT