Unified Diff: messageResponder.js
Issue 29488575:
Issue 5384 - Introduced dedicated mobile options page (Closed)
Patch Set:
Created July 13, 2017, 2:54 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« locale/en-US/mobile-options.json ('k')
|
mobile-options.html » ('j')
|
mobile-options.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: messageResponder.js |
| =================================================================== |
| --- a/messageResponder.js |
| +++ b/messageResponder.js |
| @@ -197,7 +197,15 @@ |
| port.on("app.open", (message, sender) => |
| { |
| if (message.what == "options") |
| - ext.showOptions(); |
| + { |
|
saroyanm
2017/07/18 12:46:26
Why is this change necessary ?
Thomas Greiner
2017/07/18 17:42:30
This is how we pass the domain to the options page
|
| + ext.showOptions(() => |
| + { |
| + if (!message.action) |
| + return; |
| + |
| + sendMessage("app", message.action, ...message.args); |
| + }); |
| + } |
| }); |
| port.on("filters.add", (message, sender) => |
« no previous file with comments
|
« locale/en-US/mobile-options.json ('k')
|
mobile-options.html » ('j')
|
mobile-options.html » ('J')
