Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29488592: Issue 5412 - Duplicates not allowed when packaging ABP (Closed)

Created:
July 13, 2017, 4:48 p.m. by diegocarloslima
Modified:
Aug. 9, 2017, 7:33 p.m.
Reviewers:
anton, jens
CC:
René Jeschke, Felix Dahlke
Visibility:
Public.

Description

Issue 5412 - Duplicates not allowed when packaging ABP

Patch Set 1 #

Patch Set 2 : Adjusting accordingly to #5426 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M mobile/android/installer/allowed-dupes.mn View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4
diegocarloslima
July 13, 2017, 4:50 p.m. (2017-07-13 16:50:34 UTC) #1
anton
On 2017/07/13 16:50:34, diegocarloslima wrote: LGTM
July 20, 2017, 5:36 a.m. (2017-07-20 05:36:11 UTC) #2
jens
On 2017/07/13 16:50:34, diegocarloslima wrote: LGTM with one tiny exception: You added assets/extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/bn-BD/common.properties to allowed-dupes.mn. ...
July 25, 2017, 2:41 p.m. (2017-07-25 14:41:00 UTC) #3
diegocarloslima
July 27, 2017, 12:01 p.m. (2017-07-27 12:01:40 UTC) #4
On 2017/07/25 14:41:00, jens wrote:
> On 2017/07/13 16:50:34, diegocarloslima wrote:
> 
> LGTM with one tiny exception:
> 
> You added
>
assets/extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/bn-BD/common.properties
> to allowed-dupes.mn. This file was not listed in the error log in the ticket.
> Were Bengali translations added later?

Nice catch! I will check why there was a difference from the error log and the
patch set.

Powered by Google App Engine
This is Rietveld