Issue 5373 - Remove the "blog" from acceptableads.com and link to blog.acceptableads.com

includes/sidebar/primary-navigation.tmpl

Index: includes/sidebar/primary-navigation.tmpl
===================================================================
--- a/includes/sidebar/primary-navigation.tmpl
+++ b/includes/sidebar/primary-navigation.tmpl
@@ -13,22 +13,31 @@
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with acceptableads.org.  If not, see <http://www.gnu.org/licenses/>.
  #}
 
 <ul>
   {% for sitemap_page, sitemap_parent, sitemap_children in sitemap %}
-  <li class="{% if parent == sitemap_page or page == sitemap_page %} active {% endif %} {% if sitemap_children | length > 0 %} has-submenu {% endif %}">
-    {{ sitemap_page | linkify }}{{ sitemap_parent | translate(sitemap_page, "Primary navigation label") }}</a>
-    {% if sitemap_children | length > 0 %}
-      <ul>
-      {% for sitemap_page, sitemap_child in sitemap_children %}
-        <li class="{% if page == sitemap_page %} active {% endif %}">
-          {{ sitemap_page | linkify }}{{ sitemap_child | translate(sitemap_page, "Primary navigation label under \"" + sitemap_parent + "\"") }}</a>
-        </li>
-      {% endfor %}
-      </ul>
-    {% endif %}
-  </li>
+  {% if 'http' in sitemap_page %}
+    <li>
+      <a href="{{ sitemap_page }}" target="_blank" rel="noopener noreferrer">

[ire, 2017/07/17 12:46:20]

Not sure if we typically add this, but I read that it should be included for
security/performance reasons:

- https://jakearchibald.com/2016/performance-benefits-of-rel-noopener/
-
https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vul...

[juliandoucette, 2017/07/18 16:58:50]

Does this apply to any href?
- We may want the referrer for stats on traffic from aa.com to the blog
- I think we can trust medium.com not to attack us?

[ire, 2017/07/19 12:55:22]

From what I can tell it seems like a good idea to, as a default, apply this to
external links. In this case, perhaps the noreferrer value should be excluded
since we are linking to our own blog and may want the stats. Regarding the
nofollow value, you're probably right that we can trust medium.com not to attack
us. However, there may still be some performance benefits to be gained from
using it. What do you think? Is it worth including at all?

[juliandoucette, 2017/07/19 15:03:31]

- I want to exclude `noreferrer` in this case
- I want to keep `noopener` in general

By this logic, we should add both of these `rel`s to `a`s by default and exclude
`noreferrer` if the `href` is whitelisted. But I think it's a better idea to do
this automatically via the CMS (in a separate ticket) than here (and elsewhere
in content).

I vote we remove the `rel`s here (which pose no real threat or significant
performance benefit) and create a separate Sitescripts issue to address the
potential threats and benefits globally elsewhere.

[ire, 2017/07/19 18:10:10]

I agree. It definitely makes sense to have this automated. I will remove the
attributes from this case. 

[ire, 2017/07/19 18:10:10]

Done.

+        {{ sitemap_parent | translate(sitemap_parent, "Primary navigation label") }}
+        <img src="/img/png/icon-external-link.png" srcset="/img/png/icon-external-link.png, /img/svg/icon-external-link.svg 2x" alt="External Link" class="external-icon">

[juliandoucette, 2017/07/18 16:58:50]

- missing translate filter on alt text
- the icon should be white
- the 1x icon should be 1x size

[ire, 2017/07/19 12:55:22]

Done.

+      </a>
+    </li>
+  {% else %}
+    <li class="{% if parent == sitemap_page or page == sitemap_page %} active {% endif %} {% if sitemap_children | length > 0 %} has-submenu {% endif %}">
+      {{ sitemap_page | linkify }}{{ sitemap_parent | translate(sitemap_page, "Primary navigation label") }}</a>
+      {% if sitemap_children | length > 0 %}
+        <ul>
+        {% for sitemap_page, sitemap_child in sitemap_children %}
+          <li class="{% if page == sitemap_page %} active {% endif %}">
+            {{ sitemap_page | linkify }}{{ sitemap_child | translate(sitemap_page, "Primary navigation label under \"" + sitemap_parent + "\"") }}</a>
+          </li>
+        {% endfor %}
+        </ul>
+      {% endif %}
+    </li>
+  {% endif %}
   {% endfor %}
 </ul>