chrome/content/elemHideEmulation.js - Issue 29490698: Issue 5422 - Properly build props selector

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/elemHideEmulation.js

Issue 29490698: Issue 5422 - Properly build props selector (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Updated following review. Created Aug. 19, 2017, 2:07 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/elemHideEmulation.js

===================================================================

--- a/chrome/content/elemHideEmulation.js

+++ b/chrome/content/elemHideEmulation.js

@@ -275,16 +275,19 @@

dependsOnStyles: true,

*findPropsSelectors(styles, prefix, regexp)

{

for (let style of styles)

if (regexp.test(style.style))

for (let subSelector of style.subSelectors)

{

+ if (subSelector.startsWith("*") &&

+ !incompletePrefixRegexp.test(prefix))

+ subSelector = subSelector.substr(1);

Wladimir Palant 2017/08/19 07:39:13 Nit: we require brackets around the if body for mu

hub 2017/08/21 15:36:04 Done.

let idx = subSelector.lastIndexOf("::");

if (idx != -1)

subSelector = subSelector.substr(0, idx);

yield prefix + subSelector;

}

*getSelectors(prefix, subtree, styles)

« no previous file with comments | « no previous file | no next file » | no next file with comments »