includes/styleguide/style.html - Issue 29491561: Issue 5413 - Create basic style guide for website-defaults

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/styleguide/style.html

Issue 29491561: Issue 5413 - Create basic style guide for website-defaults (Closed)

Patch Set: Apply patch against CMS compatible website-defaults Created Aug. 8, 2017, 3:49 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <style>
	ire 2017/08/08 15:54:05 I added these basic styles for readability. I didn I added these basic styles for readability. I didn't think it made sense to style the actual styleguide sections with styles for the website the styleguide is for, if that makes sense. Let me know if you think otherwise. juliandoucette 2017/08/09 12:06:53 Acknowledged. Show quoted text On 2017/08/08 15:54:05, ire wrote: > I added these basic styles for readability. I didn't think it made sense to > style the actual styleguide sections with styles for the website the styleguide > is for, if that makes sense. Let me know if you think otherwise. Acknowledged.
	2

	3 .sg-body
	juliandoucette 2017/08/09 12:06:53 I think that the parent `.container` class (which I think that the parent `.container` class (which is already applied by `default.tmpl`) and the body styles in `demo.css` cover what you are doing here. ire 2017/08/09 16:50:30 Acknowledged. Done. Show quoted text On 2017/08/09 12:06:53, juliandoucette wrote: > I think that the parent `.container` class (which is already applied by > `default.tmpl`) and the body styles in `demo.css` cover what you are doing here. Acknowledged. Done.
	4 {

	5 margin: 70px auto;

	6 padding: 0 20px;

	7 max-width: 700px;

	8 }

	9

	10 .sg-section
	juliandoucette 2017/08/09 12:06:53 I think we could replace this with a default secti I think we could replace this with a default section spacing scheme in the future. For now, I think the margin provided by the section headings is enough. ire 2017/08/09 16:50:30 Done. Show quoted text On 2017/08/09 12:06:53, juliandoucette wrote: > I think we could replace this with a default section spacing scheme in the > future. For now, I think the margin provided by the section headings is enough. Done.
	11 {

	12 margin-bottom: 50px !important;

	13 }

	14

	15 </style>

OLD	NEW

« no previous file with comments | « includes/styleguide/lists/unordered.md ('k') | includes/styleguide/typography/blockquotes.md » ('j') | includes/styleguide/typography/code.md » ('J')