includes/styleguide/typography/index.md - Issue 29491561: Issue 5413 - Create basic style guide for website-defaults

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/styleguide/typography/index.md

Issue 29491561: Issue 5413 - Create basic style guide for website-defaults (Closed)

Patch Set: Use includes for each demo Created Aug. 10, 2017, 9:52 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1

	2 ## Typography { #typography }
	juliandoucette 2017/08/10 16:49:29 Regarding the use of Markdown vs HTML: - We (cont Regarding the use of Markdown vs HTML: - We (content and website developers) have agreed to prefer HTML - Therefore a styleguide for our sake should be based in HTML - We (Websites Infrastructure) support Markdown for the sake of non-(content\|website)-developers - Mixing markdown with includes may be confusing for non-developers Therefore I would propose that we create two styleguides: 1. For website developers (with includes and additional components) 2. For non-content-developers (minimal, without includes, without components e.g. grid) - Sorry for the confusion :( - If you agree then we could review one or two of these style guides in this review ire 2017/08/11 11:09:47 Okay this makes sense. If we are intending that no Show quoted text On 2017/08/10 16:49:29, juliandoucette wrote: > Regarding the use of Markdown vs HTML: > > - We (content and website developers) have agreed to prefer HTML > - Therefore a styleguide for our sake should be based in HTML > - We (Websites Infrastructure) support Markdown for the sake of > non-(content\|website)-developers > - Mixing markdown with includes may be confusing for non-developers > > Therefore I would propose that we create two styleguides: > > 1. For website developers (with includes and additional components) > 2. For non-content-developers (minimal, without includes, without components > e.g. grid) Okay this makes sense. If we are intending that non-content-developers will look at the markup/markdown in order to see how things work, you're right that it should be without includes and plainly in markdown. Show quoted text > - Sorry for the confusion :( No worries :) Show quoted text > - If you agree then we could review one or two of these style guides in this > review I agree :)
	3

	4 ### Headings { #headings }
	juliandoucette 2017/08/10 16:49:29 NIT: Please separate markdown headings by one blan NIT: Please separate markdown headings by one blank line ire 2017/08/11 11:09:47 Done. Show quoted text On 2017/08/10 16:49:29, juliandoucette wrote: > NIT: Please separate markdown headings by one blank line Done.
	5 <? include styleguide/typography/headings ?>

	6

	7 ### Body content { #body-content }

	8 <? include styleguide/typography/body ?>

	9

	10 ### Blockquotes { #blockquotes }

	11 <? include styleguide/typography/blockquotes ?>

OLD	NEW

« no previous file with comments | « includes/styleguide/typography/headings.md ('k') | pages/content.html » ('j') | pages/content.html » ('J')