Unified Diff: pages/grid.html
Issue 29491561:
Issue 5413 - Create basic style guide for website-defaults (Closed)
Patch Set: Use includes for each demo
Created Aug. 10, 2017, 9:52 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« pages/content.html ('K')
|
« pages/content.html ('k')
|
pages/index.html » ('j')
|
pages/styleguide.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: pages/grid.html |
| =================================================================== |
| --- a/pages/grid.html |
| +++ b/pages/grid.html |
| @@ -8,69 +8,32 @@ |
| <li><a href="#tablet">Tablet</a></li> |
| <li><a href="#mobile">Mobile</a></li> |
| <li><a href="#reverse">Reverse</a></li> |
| <li><a href="#right-to-left">Right-to-left</a></li> |
| <li><a href="#reverse-and-right-to-left">Reverse & right-to-left</a></li> |
| </ol> |
| <h2 id="desktop">Desktop</h2> |
| -<div class="row"> |
| - <div class="one-half column"><p class="inverse-text">One half</p></div> |
| - <div class="one-half column"><p class="inverse-text">One half</p></div> |
| -</div> |
| -<div class="row"> |
| - <div class="one-third column"><p class="inverse-text">One third</p></div> |
| - <div class="two-thirds column"><p class="inverse-text">Two thirds</p></div> |
| -</div> |
| -<div class="row"> |
| - <div class="one-fourth column"><p class="inverse-text">One fourth</p></div> |
| - <div class="three-fourths column"><p class="inverse-text">Three fourths</p></div> |
| -</div> |
| +<? include styleguide/grid/all ?> |
|
juliandoucette
2017/08/10 16:49:30
NIT: "all" is not very descriptive
Suggest: "colum
ire
2017/08/11 11:09:47
Done. Changed to "all-column-widths", since the ot
juliandoucette
2017/08/20 16:48:39
Acknowledged.
|
| <h2 id="tablet">Tablet</h2> |
| <div class="tablet"> |
| - <div class="row"> |
| - <div class="one-half column"><p class="inverse-text">One half</p></div> |
| - </div> |
| - <div class="row"> |
| - <div class="one-third column"><p class="inverse-text">One third</p></div> |
| - </div> |
| - <div class="row"> |
| - <div class="one-fourth column"><p class="inverse-text">One fourth</p></div> |
| - <div class="one-fourth column"><p class="inverse-text">One fourth</p></div> |
| - </div> |
| +<? include styleguide/grid/all ?> |
|
juliandoucette
2017/08/10 16:49:31
NIT: Please indent
ire
2017/08/11 11:09:48
Done.
|
| </div> |
| <h2 id="mobile">Mobile</h2> |
| <div class="mobile"> |
| - <div class="row"> |
| - <div class="one-half column"><p class="inverse-text">One half</p></div> |
| - </div> |
| - <div class="row"> |
| - <div class="one-third column"><p class="inverse-text">One third</p></div> |
| - </div> |
| - <div class="row"> |
| - <div class="one-fourth column"><p class="inverse-text">One fourth</p></div> |
| - </div> |
| +<? include styleguide/grid/all ?> |
| </div> |
| <h2 id="reverse">Reverse</h2> |
| -<div class="row reverse"> |
| - <div class="one-half column"><p class="inverse-text">First</p></div> |
| - <div class="one-half column"><p class="inverse-text">Second</p></div> |
| -</div> |
| +<? include styleguide/grid/reversed ?> |
|
juliandoucette
2017/08/10 16:49:30
NIT: "reversed" what?
Suggest: Replace this includ
ire
2017/08/11 11:09:48
Done.
|
| <h2 id="right-to-left">Right-to-left</h2> |
| <div dir="rtl"> |
| - <div class="row"> |
| - <div class="one-half column"><p class="inverse-text">First</p></div> |
| - <div class="one-half column"><p class="inverse-text">Second</p></div> |
| - </div> |
| +<? include styleguide/grid/2-column ?> |
| </div> |
| <h2 id="reverse-and-right-to-left">Reverse & right-to-left</h2> |
| <div dir="rtl"> |
| - <div class="row reverse"> |
| - <div class="one-half column"><p class="inverse-text">First</p></div> |
| - <div class="one-half column"><p class="inverse-text">Second</p></div> |
| - </div> |
| +<? include styleguide/grid/reversed ?> |
| </div> |
« pages/content.html ('K')
|
« pages/content.html ('k')
|
pages/index.html » ('j')
|
pages/styleguide.html » ('J')
