Issue 5426 - ABP isn't packaged in the apk

mobile/android/base/java/org/mozilla/gecko/distribution/Distribution.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko.distribution;
 
 import java.io.BufferedInputStream;
 import java.io.File;
 import java.io.FileNotFoundException;
@@ skipping 431 matching lines @@
         ThreadUtils.assertNotOnUiThread();
 
         // Firefox for Android normally ignores application scope extensions,
         // and thus doesn't put the extensions directory in place. In Adblock
         // Browser however, we need this mechanism.
         //
         // This logic doesn't really belong here. However, here the change is
         // minimally invasive, and we're more likely to notice when the logic
         // changes for the distributions directory.
         try {
-            copyExtensionsFiles();
+            copyExtensionsFromPackagedAssets();
         } catch (IOException e) {
             Log.e(LOGTAG, "Error copying extensions files from APK.", e);
         }
 
         // Bail if we've already tried to initialize the distribution, and
         // there wasn't one.
         final SharedPreferences settings = getSharedPreferences();
 
         final String keyName = getKeyName();
         this.state = settings.getInt(keyName, STATE_UNKNOWN);
@@ skipping 301 matching lines @@
                 }
             }
         } finally {
             zip.close();
         }
 
         return distributionSet;
     }
 
     /**
-     * Copies the /extensions folder out of the APK and into the app's data directory.
-     * Adapted from copyFiles().
+     * Copies the /assets/extensions folder out of the APK and into the app's data directory.
+     * Adapted from copyFilesFromPackagedAssets().
      */
-    private void copyExtensionsFiles() throws IOException {
+    private void copyExtensionsFromPackagedAssets() throws IOException {
         final File applicationPackage = new File(packagePath);
         final ZipFile zip = new ZipFile(applicationPackage);
 
+        final String assetsPrefix = "assets/";
+        final String fullPrefix = assetsPrefix + "extensions/";
+
         try {
             final byte[] buffer = new byte[1024];
 
             final Enumeration<? extends ZipEntry> zipEntries = zip.entries();
             while (zipEntries.hasMoreElements()) {
                 final ZipEntry fileEntry = zipEntries.nextElement();
                 final String name = fileEntry.getName();
 
                 if (fileEntry.isDirectory()) {
                     // We'll let getDataFile deal with creating the directory hierarchy.
                     continue;
                 }
 
-                if (!name.startsWith("extensions/")) {
+                // Read from "assets/extensions/**".
+                if (!name.startsWith(fullPrefix)) {
                     continue;
                 }
 
-                final File outFile = getDataFile(name);
+                // Write to "extensions/**".
+                final String nameWithoutPrefix = name.substring(assetsPrefix.length());
+                final File outFile = getDataFile(nameWithoutPrefix);
                 if (outFile == null) {
                     continue;
                 }
 
                 final InputStream fileStream = zip.getInputStream(fileEntry);
                 try {
                     writeStream(fileStream, outFile, fileEntry.getTime(), buffer);
                 } finally {
                     fileStream.close();
                 }
@@ skipping 187 matching lines @@
     private SharedPreferences getSharedPreferences() {
         final SharedPreferences settings;
         if (prefsBranch == null) {
             settings = GeckoSharedPrefs.forApp(context);
         } else {
             settings = context.getSharedPreferences(prefsBranch, Activity.MODE_PRIVATE);
         }
         return settings;
     }
 }