Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29492585: Issue 5429 - Set ObjectExpression option of indent ESLint rule to first (Closed)

Created:
July 19, 2017, 1:58 p.m. by Manish Jethani
Modified:
Aug. 18, 2017, 12:06 p.m.
Base URL:
https://hg.adblockplus.org/codingtools
Visibility:
Public.

Description

Issue 5429 - Set ObjectExpression option of indent ESLint rule to first

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M eslint-config-eyeo/index.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
Manish Jethani
July 19, 2017, 1:58 p.m. (2017-07-19 13:58:48 UTC) #1
Manish Jethani
Patch Set 1 This is the bare minimum we need to do to make eslint-config-eyeo ...
July 19, 2017, 2 p.m. (2017-07-19 14:00:13 UTC) #2
Sebastian Noack
Is this patch still relevant? The issue has already been closed as fixed.
Aug. 18, 2017, 11:02 a.m. (2017-08-18 11:02:50 UTC) #3
Manish Jethani
On 2017/08/18 11:02:50, Sebastian Noack wrote: > Is this patch still relevant? The issue has ...
Aug. 18, 2017, 11:09 a.m. (2017-08-18 11:09:04 UTC) #4
Manish Jethani
On 2017/08/18 11:09:04, Manish Jethani wrote: > This charge is no longer necessary [...] *change
Aug. 18, 2017, 11:13 a.m. (2017-08-18 11:13:47 UTC) #5
kzar
Aug. 18, 2017, 12:06 p.m. (2017-08-18 12:06:13 UTC) #6
Message was sent while issue was closed.
On 2017/08/18 11:09:04, Manish Jethani wrote:
> But this will have to be done at some point because we're not going to use
> legacy mode forever. Maybe we should go ahead and make this change anyway?
Dave,
> what do you think?

I agree we should switch away from legacy indent at some point. I opened issue
#5449 so we could all discuss how we'd like our indentation rules to look.

Powered by Google App Engine
This is Rietveld