Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29492590: Issue 5432 - No android_package_name string resource found (Closed)

Created:
July 19, 2017, 4:06 p.m. by diegocarloslima
Modified:
Aug. 7, 2017, 9:45 p.m.
Reviewers:
anton, jens
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5432 - No android_package_name string resource found

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -68 lines) Patch
R mobile/android/base/resources/xml-v11/preferences_abb_abp.xml View 1 chunk +0 lines, -47 lines 0 comments Download
M mobile/android/base/resources/xml/preferences_abb_abp.xml View 1 chunk +13 lines, -21 lines 1 comment Download

Messages

Total messages: 4
diegocarloslima
July 19, 2017, 4:07 p.m. (2017-07-19 16:07:53 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29492590/diff/29492591/mobile/android/base/resources/xml/preferences_abb_abp.xml File mobile/android/base/resources/xml/preferences_abb_abp.xml (left): https://codereview.adblockplus.org/29492590/diff/29492591/mobile/android/base/resources/xml/preferences_abb_abp.xml#oldcode16 mobile/android/base/resources/xml/preferences_abb_abp.xml:16: android:dependency="android.not_a_preference.adblockbrowser.apiAdblockPlusEnabled" > There are some indentation adjustments required in ...
July 19, 2017, 4:12 p.m. (2017-07-19 16:12:02 UTC) #2
anton
On 2017/07/19 16:12:02, diegocarloslima wrote: > https://codereview.adblockplus.org/29492590/diff/29492591/mobile/android/base/resources/xml/preferences_abb_abp.xml > File mobile/android/base/resources/xml/preferences_abb_abp.xml (left): > > https://codereview.adblockplus.org/29492590/diff/29492591/mobile/android/base/resources/xml/preferences_abb_abp.xml#oldcode16 > ...
July 20, 2017, 5:35 a.m. (2017-07-20 05:35:08 UTC) #3
jens
July 25, 2017, 2:26 p.m. (2017-07-25 14:26:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld