Makefile - Issue 29493555: Issue 5433 - rename v8.gypi to build-v8.gyp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: Makefile

Issue 29493555: Issue 5433 - rename v8.gypi to build-v8.gyp (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created July 20, 2017, 9:14 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index 43673969f9b1c064c77b94cf3d5c2b3d5b2fb182..1ffeee87db2d51a7a52d35797bce26e19362e6bc 100644

--- a/Makefile

+++ b/Makefile

@@ -42,7 +42,7 @@ ensure_dependencies:

python ensure_dependencies.py

v8: ensure_dependencies

- GYP_DEFINES="${GYP_PARAMETERS}" third_party/gyp/gyp --depth=. -f make -I v8.gypi --generator-output=build/v8 ${V8_DIR}src/v8.gyp

+ GYP_DEFINES="${GYP_PARAMETERS}" third_party/gyp/gyp --depth=. -f make -I build-v8.gypi --generator-output=build/v8 ${V8_DIR}src/v8.gyp

make -C build/v8 v8_snapshot v8_libplatform v8_libsampler

all: v8

« no previous file with comments | « no previous file | android-v8-options.gypi » ('j') | no next file with comments »