Issue 5438 - Observer DOM changes to reapply filters.

lib/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const {filterToRegExp, splitSelector} = require("common");
 
+let MIN_INVOCATION_INTERVAL = 3000;
 const MAX_SYNCHRONOUS_PROCESSING_TIME = 50;
 const abpSelectorRegexp = /:-abp-([\w-]+)\(/i;
 
 /** Return position of node from parent.
  * @param {Node} node the node to find the position of.
  * @return {number} One-based index like for :nth-child(), or 0 on error.
  */
 function positionInParent(node)
 {
   let {children} = node.parentNode;
@@ skipping 462 matching lines @@
           return;
         }
       }
       pattern = null;
       return processPatterns();
     };
 
     processPatterns();
   },
 
-  _MIN_INVOCATION_INTERVAL: 3000,
-
-  set _invocationInterval(interval)
-  {
-    this._MIN_INVOCATION_INTERVAL = interval;
-    if (this._lastInvocation < 0)
-      this._lastInvocation = -interval;
+  // This property is only used in the tests
+  // to shorten the invocation interval
+  get MIN_INVOCATION_INTERVAL()
+  {
+    return MIN_INVOCATION_INTERVAL;
+  },
+
+  set MIN_INVOCATION_INTERVAL(interval)
+  {
+    MIN_INVOCATION_INTERVAL = interval;
   },

[Wladimir Palant, 2017/08/25 07:44:58]

You can have a setter without a getter but that's not nice to say the least.
Given that this is really for tests only, maybe it's best to keep the
MIN_INVOCATION_INTERVAL global around and merely make it non-constant. Then you
could add a getter/setter combination here and note in a comment that unit tests
need to change this constant:

  get MIN_INVOCATION_INTERVAL()
  {
    return MIN_INVOCATION_INTERVAL;
  },

  set MIN_INVOCATION_INTERVAL(interval)
  {
    MIN_INVOCATION_INTERVAL = interval;
  }

[hub, 2017/08/25 13:48:12]

Done.

 
   _filteringInProgress: false,
-  _lastInvocation: -this._MIN_INVOCATION_INTERVAL,

[Wladimir Palant, 2017/08/25 07:44:58]

This assignment won't work, `this` isn't pointing to the (not yet existent)
object.

[hub, 2017/08/25 13:48:12]

oops.

+  _lastInvocation: -MIN_INVOCATION_INTERVAL,
   _scheduledProcessing: null,
 
   /**
    * Re-run filtering either immediately or queued.
    * @param {CSSStyleSheet[]} [stylesheets]
    *    new stylesheets to be processed. This parameter should be omitted
    *    for DOM modification (full reprocessing required).
    */
   queueFiltering(stylesheets)
   {
@@ skipping 14 matching lines @@
       if (!stylesheets)
         this._scheduledProcessing.stylesheets = null;
       else if (this._scheduledProcessing.stylesheets)
         this._scheduledProcessing.stylesheets.push(...stylesheets);
     }
     else if (this._filteringInProgress)
     {
       this._scheduledProcessing = {stylesheets};
     }
     else if (this.window.performance.now() -
-             this._lastInvocation < this._MIN_INVOCATION_INTERVAL)
+             this._lastInvocation < MIN_INVOCATION_INTERVAL)
     {
       this._scheduledProcessing = {stylesheets};
       this.window.setTimeout(() =>
       {
         let newStylesheets = this._scheduledProcessing.stylesheets;
         this._filteringInProgress = true;
         this._scheduledProcessing = null;
         this._addSelectors(newStylesheets, completion);
       },
-      this._MIN_INVOCATION_INTERVAL -
+      MIN_INVOCATION_INTERVAL -
       (this.window.performance.now() - this._lastInvocation));
     }
     else
     {
       this._filteringInProgress = true;
       this._addSelectors(stylesheets, completion);
     }
   },
 
   onLoad(event)
@@ skipping 33 matching lines @@
             subtree: true
           }
         );
         document.addEventListener("load", this.onLoad.bind(this), true);
       }
     });
   }
 };
 
 exports.ElemHideEmulation = ElemHideEmulation;