Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29496585: Noissue - move host detecting script into libadblockplus repo (Closed)

Created:
July 24, 2017, 12:54 p.m. by sergei
Modified:
July 25, 2017, 12:33 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

Without that change one has to firstly manually run ensure_dependency.py (see Makefile) as well as it's still required to fetch v8 source even if there is already built V8. Codereview: https://codereview.adblockplus.org/29496585/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A third_party/detect_v8_host_arch.py View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sergei
July 24, 2017, 12:58 p.m. (2017-07-24 12:58:27 UTC) #1
hub
July 24, 2017, 5:20 p.m. (2017-07-24 17:20:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld