dependencies - Issue 29498563: Issue 5133 - add CI for libadblockplus

Side by Side Diff: dependencies

Issue 29498563: Issue 5133 - add CI for libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created July 26, 2017, 12:31 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:6ab9eb46db2a git:2f2bf1f217314022327d4bd9c39002e9248d cf7f	3 buildtools = buildtools hg:6ab9eb46db2a git:2f2bf1f217314022327d4bd9c39002e9248d cf7f

4 adblockpluscore = adblockpluscore hg:103fdc164738 git:199dffdec708afd3913665e358 2868aa4a110d97	4 adblockpluscore = adblockpluscore hg:103fdc164738 git:199dffdec708afd3913665e358 2868aa4a110d97

5 third_party/googletest = googletest-github hg:368e1f54e5f6 git:d225acc90bc3a8c42 0a9bcd1f033033c1ccd7fe0	5 third_party/googletest = googletest-github hg:368e1f54e5f6 git:d225acc90bc3a8c42 0a9bcd1f033033c1ccd7fe0

6 third_party/gyp = gyp hg:2488397072ad git:8ffe7e7b1b82890a7e9ea21176bf039b6c5316 7b	6 third_party/gyp = gyp hg:2488397072ad git:8ffe7e7b1b82890a7e9ea21176bf039b6c5316 7b

7 third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe 309ba9c2e3081
sergei 2017/07/26 12:52:52 Don't spend time on pulling v8 because we use preb Don't spend time on pulling v8 because we use prebuilt V8. hub 2017/07/26 15:35:51 the problem is that this break local builds that e Show quoted text On 2017/07/26 12:52:52, sergei wrote: > Don't spend time on pulling v8 because we use prebuilt V8. the problem is that this break local builds that expect to have it to build. sergei 2017/07/26 15:44:40 Right :) I applied this commit each time for CI bu Show quoted text On 2017/07/26 15:35:51, hub wrote: > On 2017/07/26 12:52:52, sergei wrote: > > Don't spend time on pulling v8 because we use prebuilt V8. > > the problem is that this break local builds that expect to have it to build. Right :) I applied this commit each time for CI but we may not commit it. However, I still think we should not fetch V8 each time when we don't need it, it takes at least few minutes and for free CI where the builds run sequentially it can significantly increase the building time. What about removing these lines from CI config? hub 2017/07/26 15:51:53 I'm ok with not fetching it when running on CI. Ca Show quoted text On 2017/07/26 15:44:40, sergei wrote: > On 2017/07/26 15:35:51, hub wrote: > > On 2017/07/26 12:52:52, sergei wrote: > > > Don't spend time on pulling v8 because we use prebuilt V8. > > > > the problem is that this break local builds that expect to have it to build. > > Right :) I applied this commit each time for CI but we may not commit it. > > However, I still think we should not fetch V8 each time when we don't need it, > it takes at least few minutes and for free CI where the builds run sequentially > it can significantly increase the building time. What about removing these lines > from CI config? I'm ok with not fetching it when running on CI. Can we have "conditionals" with ensure_dependencies? That's probably something we'd want to do. sergei 2017/07/26 16:45:46 ensure_dependencies.py does not support something Show quoted text On 2017/07/26 15:51:53, hub wrote: > On 2017/07/26 15:44:40, sergei wrote: > > On 2017/07/26 15:35:51, hub wrote: > > > On 2017/07/26 12:52:52, sergei wrote: > > > > Don't spend time on pulling v8 because we use prebuilt V8. > > > > > > the problem is that this break local builds that expect to have it to build. > > > > Right :) I applied this commit each time for CI but we may not commit it. > > > > However, I still think we should not fetch V8 each time when we don't need it, > > it takes at least few minutes and for free CI where the builds run > sequentially > > it can significantly increase the building time. What about removing these > lines > > from CI config? > > I'm ok with not fetching it when running on CI. Can we have "conditionals" with > ensure_dependencies? That's probably something we'd want to do. ensure_dependencies.py does not support something like this, it can be only globally disabled. I have added a command removing lines containing "third_party/v8".
8 third_party/v8/base/trace_event/common = chromium-trace_event-common hg:afa6c508 d4a7 git:06294c8a4a6f744ef284cd63cfe54dbf61eea290

9 third_party/v8/build = chromium-src-build hg:71b1606b07cf git:3983535ba9ae6e2dc5 01e59fde158018d811f95c

10 third_party/v8/testing/gtest = googletest-github hg:324727ee9ad7 git:6f8a66431cb 592dad629028a50b3dd418a408c87

11 third_party/v8/tools/gyp = gyp hg:9282ef983052 git:e7079f0e0e14108ab0dba58728ff2 19637458563

12 third_party/v8/tools/clang = chromium-src-tools-clang hg:24cee4531b21 git:286099 f3928097ad1602710b550dfc1ff5c22142

13 third_party/v8/third_party/icu = chromium-deps-icu hg:dcc0a556c207 git:9cd282874 0572ba6f694b9365236a8356fd06147

OLD	NEW

« appveyor.yml ('K') | « appveyor.yml ('k') | no next file » | no next file with comments »