Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/BaseJsTest.h

Issue 29499574: Issue 5183 - don't inherit ThrowingFileSystem from sync FileSystem (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 27, 2017, 8:47 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/BaseJsTest.h
diff --git a/test/BaseJsTest.h b/test/BaseJsTest.h
index c229ad3185d6c17b10c1a765a97718d741b61f78..522267058338b360d3befda28e1d3ba6bb7174cd 100644
--- a/test/BaseJsTest.h
+++ b/test/BaseJsTest.h
@@ -104,59 +104,37 @@ public:
}
};
-class ThrowingFileSystem : public AdblockPlus::IFileSystem, public AdblockPlus::FileSystem
+class ThrowingFileSystem : public AdblockPlus::IFileSystem
{
public:
- IOBuffer Read(const std::string& path) const
- {
- throw std::runtime_error("Not implemented");
- }
- void Read(const std::string& path,
- const ReadCallback& callback) const
+ void Read(const std::string& path, const ReadCallback& callback) const override
{
throw std::runtime_error("Not implemented");
}
- void Write(const std::string& path, const IOBuffer& content)
- {
- throw std::runtime_error("Not implemented");
- }
void Write(const std::string& path, const IOBuffer& data,
- const Callback& callback)
+ const Callback& callback) override
{
throw std::runtime_error("Not implemented");
}
- void Move(const std::string& fromPath, const std::string& toPath)
- {
- throw std::runtime_error("Not implemented");
- }
void Move(const std::string& fromPath, const std::string& toPath,
- const Callback& callback)
+ const Callback& callback) override
{
throw std::runtime_error("Not implemented");
}
- void Remove(const std::string& path)
- {
- throw std::runtime_error("Not implemented");
- }
- void Remove(const std::string& path, const Callback& callback)
+ void Remove(const std::string& path, const Callback& callback) override
{
throw std::runtime_error("Not implemented");
}
- StatResult Stat(const std::string& path) const
- {
- throw std::runtime_error("Not implemented");
- }
- void Stat(const std::string& path,
- const StatCallback& callback) const
+ void Stat(const std::string& path, const StatCallback& callback) const override
{
throw std::runtime_error("Not implemented");
}
- std::string Resolve(const std::string& path) const
+ std::string Resolve(const std::string& path) const override
{
throw std::runtime_error("Not implemented");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld