Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29499580: Noissue - remove unnecessary sleeps in FileSystemJsObject tests (Closed)

Created:
July 27, 2017, 8:50 a.m. by sergei
Modified:
July 27, 2017, 12:30 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

The mock implementation calls callbacks immediately, so there is no need in additional waiting. Review: https://codereview.adblockplus.org/29499580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M test/FileSystemJsObject.cpp View 7 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2
sergei
July 27, 2017, 8:52 a.m. (2017-07-27 08:52:26 UTC) #1
hub
July 27, 2017, 12:17 p.m. (2017-07-27 12:17:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld