Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/Notification.cpp

Issue 29499583: Issue 4938 - fix race conditions related to LazyFileSystem (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 27, 2017, 8:53 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/Notification.cpp
diff --git a/test/Notification.cpp b/test/Notification.cpp
index 376ea08147e5547b6fc52f5182c5a911db2e8e05..b5f487080ad409d5b0da8ca268c804ec958710a3 100644
--- a/test/Notification.cpp
+++ b/test/Notification.cpp
@@ -33,13 +33,14 @@ namespace
FilterEnginePtr filterEngine;
void SetUp()
{
+ LazyFileSystem* fileSystem;
JsEngineCreationParameters jsEngineParams;
- jsEngineParams.fileSystem.reset(new LazyFileSystem());
+ jsEngineParams.fileSystem.reset(fileSystem = new LazyFileSystem());
jsEngineParams.logSystem.reset(new DefaultLogSystem());
jsEngineParams.timer.reset(new NoopTimer());
jsEngineParams.webRequest.reset(new NoopWebRequest());
auto jsEngine = CreateJsEngine(std::move(jsEngineParams));
- filterEngine = FilterEngine::Create(jsEngine);
+ filterEngine = CreateFilterEngine(*fileSystem, jsEngine);
}
void AddNotification(const std::string& notification)
« test/FilterEngine.cpp ('K') | « test/FilterEngine.cpp ('k') | test/Prefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld