Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 29499592: Issue 5183 - remove synchronous FileSystem interface and stop exposing of DefaultFileSystem (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by sergei
Modified:
2 years, 2 months ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# depends on # - https://codereview.adblockplus.org/29499583/ # - https://codereview.adblockplus.org/29499574/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -196 lines) Patch
M include/AdblockPlus.h View 1 chunk +0 lines, -2 lines 0 comments Download
D include/AdblockPlus/DefaultFileSystem.h View 1 chunk +0 lines, -79 lines 0 comments Download
D include/AdblockPlus/FileSystem.h View 1 chunk +0 lines, -88 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + src/DefaultFileSystem.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/DefaultFileSystem.cpp View 6 chunks +13 lines, -18 lines 0 comments Download
M src/FileSystemJsObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/JsEngine.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
sergei
2 years, 2 months ago (2017-07-27 09:20:22 UTC) #1
hub
2 years, 2 months ago (2017-07-27 13:15:47 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5