Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/index/media.tmpl

Issue 29499714: Issue 4912 - Update media coverage links on eyeo.com (Closed) Base URL: https://hg.adblockplus.org/web.eyeo.com
Left Patch Set: Created July 27, 2017, 4:46 p.m.
Right Patch Set: Refactor alternative text and title for media coverage links Created Aug. 2, 2017, 10:33 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 {% set media_coverage = [
2 {
3 "url": "http://www.mediapost.com/publications/article/289691/adblock-plus-co mes-to-new-york.html",
4 "publisher": "Media Post",
5 "image": "media-post"
6 },
7 {
8 "url": "https://www.nytimes.com/2015/08/20/technology/personaltech/ad-blocke rs-and-the-nuisance-at-the-heart-of-the-modern-web.html",
9 "publisher": "The New York Times",
10 "image": "new-york-times"
11 },
12 {
13 "url": "https://www.wsj.com/articles/adblock-plus-chief-till-faida-says-cons umers-are-fed-up-with-current-online-ads-1462981668",
14 "publisher": "The Wall Street Journal",
15 "image": "wall-street-journal"
16 },
17 {
18 "url": "https://techcrunch.com/2016/05/09/adblock-plus-closes-in-on-a-billio n-downloads/",
19 "publisher": "TechCrunch",
20 "image": "techcrunch"
21 },
22 {
23 "url": "http://www.businessinsider.com/theres-nothing-wrong-about-the-way-ad block-plus-makes-money-2015-9",
24 "publisher": "Business Insider",
25 "image": "business-insider"
26 }
27 ] %}
28
29 {% macro media_coverage_item(item) -%}
30 <a href="{{ item.url }}" target="_blank" title="Open featured {{ item.publicat ion }} article in a new window">
31 <img class="publisher-logo" alt="{{ item.publisher }} logo" src="/images/cov erage/{{ item.image }}-1x.png" srcset="/images/coverage/{{ item.image }}-2x.png 2x">
32 <img class="external-link-icon" src="/images/icon-external-link.png" srcset= "/images/icon-external-link.svg 2x" alt="External link icon">
33 </a>
34 {% endmacro %}
35
36 <h1 class="heading">
37 <span>Media coverage:</span>
38 </h1>
39
40 <ul id="media-links">
41 {% for item in media_coverage %}
42 <li>{{ media_coverage_item(item) }}</li>
43 {% endfor %}
44 </ul>
45
46 <small>(Links open in a new window)</small>
juliandoucette 2017/08/02 20:31:13 NIT: - I think it's better to put labels above (to
LEFTRIGHT

Powered by Google App Engine
This is Rietveld