Issue 5450 - introduce the Platform class

test/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <stdexcept>
 #include "BaseJsTest.h"
 
 using namespace AdblockPlus;
 
 namespace
 {
   class JsEngineTest : public BaseJsTest
   {
+  protected:
+    JsEnginePtr jsEngine;
+    void SetUp() override
+    {
+      BaseJsTest::SetUp();
+      jsEngine = platform->GetJsEngine();
+    }
   };
 }
 
 TEST_F(JsEngineTest, Evaluate)
 {
   jsEngine->Evaluate("function hello() { return 'Hello'; }");
   auto result = jsEngine->Evaluate("hello()");
   ASSERT_TRUE(result.IsString());
   ASSERT_EQ("Hello", result.AsString());
 }
@@ skipping 120 matching lines @@
 
   // Remove callback
   jsEngine->RemoveEventCallback("foobar");
   callbackCalled = false;
   jsEngine->Evaluate("_triggerEvent('foobar')");
   ASSERT_FALSE(callbackCalled);
 }
 
 TEST(NewJsEngineTest, GlobalPropertyTest)
 {
-  AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
+  Platform platform{ThrowingPlatformCreationParameters()};
+  auto jsEngine = platform.GetJsEngine();
   jsEngine->SetGlobalProperty("foo", jsEngine->NewValue("bar"));
   auto foo = jsEngine->Evaluate("foo");
   ASSERT_TRUE(foo.IsString());
   ASSERT_EQ(foo.AsString(), "bar");
 }
 
 TEST(NewJsEngineTest, MemoryLeak_NoCircularReferences)
 {
   std::weak_ptr<AdblockPlus::JsEngine> weakJsEngine;
   {
-    weakJsEngine = AdblockPlus::JsEngine::New();
+    weakJsEngine = Platform{ThrowingPlatformCreationParameters()}.GetJsEngine();
   }
   EXPECT_FALSE(weakJsEngine.lock());
 }
 
 #if UINTPTR_MAX == UINT32_MAX // detection of 32-bit platform
 static_assert(sizeof(intptr_t) == 4, "It should be 32bit platform");
 TEST(NewJsEngineTest, 32bitsOnly_MemoryLeak_NoLeak)
 #else
 TEST(NewJsEngineTest, DISABLED_32bitsOnly_MemoryLeak_NoLeak)
 #endif
 {
   // v8::Isolate by default requires 32MB (depends on platform), so if there is
   // a memory leak than we will run out of memory on 32 bit platform because it
   // will allocate 32000 MB which is less than 2GB where it reaches out of
   // memory. Even on android where it allocates initially 16MB, the test still
   // makes sense.
   for (int i = 0; i < 1000; ++i)
   {
-    AdblockPlus::JsEngine::New();
+    Platform{ThrowingPlatformCreationParameters()}.GetJsEngine();
   }
 }