Issue 5383 - Add tests for the Chrome and Firefox packagers

ensure_dependencies.py

 #!/usr/bin/env python
 
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import sys
 import os
 import posixpath
 import re
@@ skipping 326 matching lines @@
         if level == 0:
             logging.warning('No dependencies file in directory %s, nothing to do...\n%s' % (repodir, USAGE))
         return
     if level >= 10:
         logging.warning('Too much subrepository nesting, ignoring %s' % repo)
         return
 
     if overrideroots is not None:
         config['_root'] = overrideroots
 
+    # F823
+    vcs = None

[kzar, 2017/10/16 11:17:24]

What's the idea with this change? The vcs variable seems kind of confusing to me
now, I also wonder if we should set it to None inside the loop?

[tlucas, 2017/10/17 12:45:40]

The change below change this to be an F823 flake8 error, rather than the
previously already ignored F821. This doesn't apply anymore, reverted it.

+
     for dir, sources in sorted(config.iteritems()):
         if (dir.startswith('_') or
             skipdependencies.intersection([s[0] for s in sources if s[0]])):
             continue
 
         target = safe_join(repodir, dir)
         parenttype = get_repo_type(repodir)
         _root = config.get('_root', {})
 
         for key in sources.keys() + _root.keys():
@@ skipping 50 matching lines @@
             for l in file_content:
                 print >>f, l
 
 
 if __name__ == '__main__':
     logging.basicConfig(format='%(levelname)s: %(message)s', level=logging.INFO)
 
     parser = argparse.ArgumentParser(description='Verify dependencies for a set of repositories, by default the repository of this script.')
     parser.add_argument('repos', metavar='repository', type=str, nargs='*', help='Repository path')
     parser.add_argument('-q', '--quiet', action='store_true', help='Suppress informational output')
+    parser.add_argument(
+        '--nodejs-only',
+        action='store_true',
+        help='Install Node.js production-only dependencies only'
+    )
     args = parser.parse_args()
 
     if args.quiet:
         logging.disable(logging.INFO)
 
-    repos = args.repos
-    if not len(repos):
-        repos = [os.path.dirname(__file__)]
-    for repo in repos:
-        resolve_deps(repo)
+    if args.nodejs_only:
+        vcs = get_repo_type('.')

[kzar, 2017/10/16 11:17:24]

I wonder why we're assigning vcs here, since we just pass it through to
resolve_npm_dependencies anyway?

Do you mean to set it in the top scope, but then override it in the function
scopes? That could violate the no_shadow ESLint rule for our JavaScript code at
least.

[tlucas, 2017/10/17 12:45:41]

This was merely meant to be temporary. Passing it directly to
resolve_npm_dependencies.

+        resolve_npm_dependencies('.', vcs)
+    else:
+        repos = args.repos
+        if not len(repos):
+            repos = [os.path.dirname(__file__)]
+        for repo in repos:
+            resolve_deps(repo)