tests/metadata.chrome - Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/metadata.chrome

Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)

Patch Set: Adjusting tests to recent changes Created Oct. 11, 2017, 4:01 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 [general]

	2 version = 1.2.3

	3 author = eyeo GmbH

	4 basename = adblockpluschrome

	5 permissions = tabs

	6 <all_urls>

	7 optionalPermissions = webRequest

	8 backgroundScripts = ext/common.js

	9 ext/background.js

	10 testScripts = ../ext/common.js

	11 ../ext/background.js

	12 devtools = devtools.html

	13 options = options.html

	14 managedStorageSchema = storage.json

	15 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-53.png popup.html

	16 icons = icons/abp-16.png

	17 webAccessible = images/*.png

	18

	19 [contentScripts]

	20 planets = content.js

	21

	22 [mapping]

	23 logo_44.png = chrome/icons/abp-44.png

	24 foo/logo_50.png = chrome/icons/abp-50.png

	25 icons/logo_150.png = chrome/icons/abp-150.png

	26

	27 [compat]

	28 chrome = 49.0

	29 opera = 36.0

	30

	31 [import_locales]

	32 _modules//module.json = =

	33 _modules//unit.properties = =

	34 _imp//gecko.dtd = =

	35

	36 [bundles]

	37 lib/foo.js = ext/a.js
	kzar 2017/10/16 11:17:29 Perhaps we should also test that webpack bundled a Perhaps we should also test that webpack bundled a file which was required from one of these entry points? E.g. if ext/a.js does `require("./c.js")` that should be included in the bundle too. tlucas 2017/10/17 12:45:47 Good point - Done. Show quoted text On 2017/10/16 11:17:29, kzar wrote: > Perhaps we should also test that webpack bundled a file which was required from > one of these entry points? E.g. if ext/a.js does `require("./c.js")` that should > be included in the bundle too. Good point - Done.
	38 lib/b.js

OLD	NEW