tests/metadata.chrome - Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tests/metadata.chrome

Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)

Left Patch Set: Addressing pep8 error from last review Created Aug. 11, 2017, 12:12 p.m.

Right Patch Set: Addressing Vasily's comments Created Oct. 22, 2017, 11:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.2.3	2 version = 1.2.3

3 author = Eyeo GmbH	3 author = eyeo GmbH

4 basename = adblockpluschrome	4 basename = adblockpluschrome

5 permissions = tabs	5 permissions = tabs

6 <all_urls>	6 <all_urls>

7 contextMenus	7 optionalPermissions = webRequest

8 webRequest

9 webRequestBlocking

10 webNavigation

11 storage

12 unlimitedStorage

13 notifications

14 backgroundScripts = ext/common.js	8 backgroundScripts = ext/common.js

15 ext/background.js	9 ext/background.js

16 lib/compat.js

17 lib/publicSuffixList.js

18 lib/adblockplus.js

19 messageResponder.js

20 background.js

21 testScripts = ../ext/common.js	10 testScripts = ../ext/common.js

22 ../ext/background.js	11 ../ext/background.js

23 ../lib/compat.js

24 devtools = devtools.html	12 devtools = devtools.html

25 options = options.html	13 options = options.html

26 managedStorageSchema = managed-storage-schema.json	14 managedStorageSchema = storage.json

	15 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-53.png popup.html

	16 icons = icons/abp-16.png

	17 webAccessible = images/*.png

27	18

28 [convert_js]	19 [contentScripts]

29 lib/foo.js =	20 planets = content.js

30 lib/a.js

31 lib/b.js

32 lib/foo.js[module] = true

33 lib/foo.js[injectinfomodule] = true

34 lib/foo.js[autoload] = icons

35	21

36 [mapping]	22 [mapping]

37 logo_44.png = chrome/icons/abp-44.png	23 logo_44.png = chrome/icons/abp-44.png

38 foo/logo_50.png = chrome/icons/abp-50.png	24 foo/logo_50.png = chrome/icons/abp-50.png

39 icons/logo_150.png = chrome/icons/abp-150.png	25 icons/logo_150.png = chrome/icons/abp-150.png

40	26

41 [compat]	27 [compat]

42 chrome = 49.0	28 chrome = 49.0

43 opera = 36.0	29 opera = 36.0

44	30

45 [import_locales]	31 [import_locales]

46 _trans/*/test.properties = name	32 _modules//module.json = =

47 name_devbuild	33 _modules//unit.properties = =

	34 _imp//gecko.dtd = =

	35

	36 [bundles]

	37 lib/foo.js = ext/a.js

	38 lib/b.js

LEFT	RIGHT