Issue 5383 - Add tests for the Chrome and Firefox packagers

tests/test_packagerEdge.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-import os
-import io
-
 import xml.etree.ElementTree as ET
-import zipfile
 
 import pytest
 
 from buildtools import packager, packagerEdge
-from buildtools.tests.tools import copy_metadata
 
 
 @pytest.fixture
-def edge_metadata(tmpdir):
-    filename = 'metadata.edge'
-    copy_metadata(filename, tmpdir)
-
-    return packager.readMetadata(str(tmpdir), 'edge')
+def files():
+    """Minimal Files() for testing blockmap."""
+    str500 = b''.join(chr(i % 200 + 30) for i in range(500))
+    files = packager.Files(set(), set())
+    files['Extension/foo.xml'] = str500
+    files['Extension/bar.png'] = str500 * 200
+    return files
 
 
 def blockmap2dict(xml_data):
     """Convert AppxBlockMap.xml to a dict of dicts easier to inspect."""
     return {
         file.get('Name'): {
             'size': file.get('Size'),
             'lfhsize': file.get('LfhSize'),
             'blocks': [b.get('Hash') for b in file]
         }
         for file in ET.fromstring(xml_data)
     }
 
 
-def test_create_appx_blockmap(base_files):
-    blockmap = blockmap2dict(packagerEdge.create_appx_blockmap(base_files))
+def test_create_appx_blockmap(files):
+    blockmap = blockmap2dict(packagerEdge.create_appx_blockmap(files))
     assert blockmap['Extension\\foo.xml'] == {
         'size': '500',
         'lfhsize': '47',
         'blocks': ['Vhwfmzss1Ney+j/ssR2QVISvFyMNBQeS2P+UjeE/di0=']
     }
     assert blockmap['Extension\\bar.png'] == {
         'size': '100000',
         'lfhsize': '47',
         'blocks': [
             'KPW2SxeEikUEGhoKmKxruUSexKun0bGXMppOqUFrX5E=',
@@ skipping 32 matching lines @@
         'js': 'application/javascript',
         'json': 'application/json',
         'otf': 'application/octet-stream',
         'png': 'image/png',
         'xml': 'application/xml'
     }
     assert ctm_dict['overrides'] == {
         '/AppxBlockMap.xml': 'application/vnd.ms-appx.blockmap+xml',
         '/AppxManifest.xml': 'application/vnd.ms-appx.manifest+xml'
     }
-
-
-@pytest.mark.parametrize('release_build', [True, False])
-def test_create_appx_manifest(base_files, srcdir, release_build,
-                              edge_metadata):
-    manifest = ET.fromstring(packagerEdge.create_appx_manifest(
-        {'metadata': edge_metadata},
-        base_files,
-        release_build=release_build))
-
-    xmlpath = os.path.join(
-        os.path.dirname(__file__),
-        'expecteddata',
-        'manifest_edge_{}.xml'.format(release_build)
-    )
-
-    with io.open(xmlpath, 'r') as fp:
-        expected = ET.fromstring(fp.read())
-
-    from buildtools.tests.tools import get_leafs_string
-    assert set(get_leafs_string(expected)) == set(get_leafs_string(manifest))
-
-
-def test_move_files_to_extension(str500chars):
-    files = packager.Files(set(), set())
-    files['foo.xml'] = str500chars
-    files['foo/bar.xml'] = str500chars
-    files['Extension/foo.xml'] = str500chars
-    packagerEdge.move_files_to_extension(files)
-    assert set(files.keys()) == {
-        'Extension/foo.xml',
-        'Extension/foo/bar.xml',
-        'Extension/Extension/foo.xml'
-    }
-
-
-@pytest.mark.usefixtures('edge_metadata')
-def test_create_build(tmpdir, srcdir):
-    out_file = str(tmpdir.join('abp.appx'))
-    packagerEdge.createBuild(str(srcdir), outFile=out_file, releaseBuild=True)
-    appx = zipfile.ZipFile(out_file)
-
-    names = set(appx.namelist())
-    assert 'AppxManifest.xml' in names
-    assert 'AppxBlockMap.xml' in names
-    assert '[Content_Types].xml' in names
-
-    assert 'devbuild-marker' not in appx.read('AppxManifest.xml')
-    assert appx.read('Assets/logo_44.png') == '44'
-    assert appx.read('Extension/icons/abp-44.png') == '44'
-
-
-@pytest.mark.usefixtures('edge_metadata')
-def test_create_devbuild(tmpdir, srcdir):
-    out_file = str(tmpdir.join('abp.appx'))
-    packagerEdge.createBuild(str(srcdir), outFile=out_file, releaseBuild=False)
-    appx = zipfile.ZipFile(out_file)
-    assert 'devbuild-marker' in appx.read('AppxManifest.xml')