Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: tests/README.md

Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)
Left Patch Set: Adjusting tests to recent changes Created Oct. 11, 2017, 4:01 p.m.
Right Patch Set: Addressing Vasily's comments Created Oct. 22, 2017, 11:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « packagerChrome.py ('k') | tests/abp-16.png » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # Buildtools unit tests 1 # Buildtools unit tests
2 2
3 ## Introduction 3 ## Introduction
4 4
5 Unit tests for buildtools, using the pytest framework. 5 Unit tests for buildtools, using the pytest framework.
6 6
7 ## Approach 7 ## Approach
8 8
9 In order to test the buildtools capability of creating WebExtension-packages 9 In order to test the buildtools capability of creating WebExtension-packages
10 for Chrome, Edge and Firefox, an example configuration for each platform is 10 for Chrome, Edge and Firefox, an example configuration for each platform is
11 provided. 11 provided.
12 Running the tests calls the same API as the cli would, except for releases 12 Running the tests calls the same API as the cli would, except for releases
13 (we don't want to trigger our releaseAutomation during tests) - in this case, 13 (we don't want to trigger our releaseAutomation during tests) - in this case,
14 a build is manually created and verified) 14 a build is manually created and verified).
kzar 2017/10/16 11:17:28 Nit: Missing full stop, same below.
tlucas 2017/10/17 12:45:42 Done - Although i couldn't find the one below.
15 15
16 Each extension is build with different parameters, the resulting package and 16 Each extension is build with different parameters, the resulting package and
17 it's content is compared against provided expected results: 17 it's content is compared against provided expected results:
18 18
19 - Release or build-only, with or without a specific build-number (Edge) 19 - Release or build-only, with or without a specific build-number (Edge)
20 - Release, build-only or developement environment, with or without a specifc 20 - Release, build-only or developement environment, with or without a specifc
21 build-number (Chrome, Firefox), with or without a predefined signing key 21 build-number (Chrome, Firefox), with or without a predefined signing key
22 (Chrome) 22 (Chrome)
23 23
24 The expected results for each manifest are provided with the files in 24 The expected results for each manifest are provided with the files in
25 `expecteddata/`. 25 `expecteddata/`.
26 26
27 ## Test cases 27 ## Test cases
28 28
29 _(covered platforms are referred to as C=Chrome, E=Edge, F=Firefox)_ 29 _(Covered platforms are referred to as C=Chrome, E=Edge, F=Firefox.)_
kzar 2017/10/16 11:17:29 Nit: Please capitalise "Covered".
tlucas 2017/10/17 12:45:43 Done.
30 30
31 - Metadata inheritance (EF) 31 - Metadata inheritance (EF)
32 - correct package filename (CEF) 32 - Correct package filename (CEF)
kzar 2017/10/16 11:17:26 Nit: "Correct"
tlucas 2017/10/17 12:45:46 Done.
33 - Printed warning about non-square icons (CF) 33 - Printed warning about non-square icons (CEF)
34 - Presence of javascript unit test files in developement environment (CF) 34 - Presence of JavaScript unit test files in developement environment (CEF)
kzar 2017/10/16 11:17:27 Nit: "JavaScript", same below.
tlucas 2017/10/17 12:45:45 Done.
35 - Absence of javascript unit test files in build-only or release (CF) 35 - Absence of JavaScript unit test files in build-only or release (CEF)
36 - Inlcusion of defined contentScripts into the manifest (CF) 36 - Inlcusion of defined contentScripts into the manifest (CEF)
37 - Packaging (and moving) of included icons / scripts / htmls (CEF) 37 - Packaging (and moving) of included icons / scripts / HTML files (CEF)
kzar 2017/10/16 11:17:25 Nit: "HTML files"
tlucas 2017/10/17 12:45:44 Done.
38 - Presence of files for all configured locales (CEF) 38 - Presence of files for all configured locales (CEF)
39 - Correct import of translations with or without placeholders, with or without 39 - Correct import of translations with or without placeholders, with or without
40 access keys (CEF) 40 access keys (CEF)
41 - Translation presence and validity for the Chrome Web Store (C) 41 - Translation presence and validity for the Chrome Web Store (C)
42 - Packaging of modularized script files (CEF) 42 - Packaging of modularized script files with webpack (CEF)
43 - Adherence to provided build-number in the manifest (CEF) 43 - Adherence to provided build-number in the manifest (CEF)
44 - Other content in the manifest (CEF) 44 - Other content in the manifest (CEF)
45 - Correct encrypted signature of the package (C) 45 - Correct encrypted signature of the package (C)
46 46
47 ## Requirements 47 ## Requirements
48 48
49 - [Tox](https://pypi.python.org/pypi/tox) (>= 2.7.0) 49 - [Tox](https://pypi.python.org/pypi/tox) (>= 2.7.0)
50 50
51 _(Tox will take care of installing the other dependencies such as flake8 and 51 _(Tox will take care of installing the other dependencies such as flake8 and
52 flake8-abp inside a virtualenv.)_ 52 flake8-abp inside a virtualenv.)_
(...skipping 11 matching lines...) Expand all
64 ## Coverage 64 ## Coverage
65 65
66 Pytest will create a coverage report as output to the terminal, using the 66 Pytest will create a coverage report as output to the terminal, using the
67 pytest plugin `pytest-cov`. 67 pytest plugin `pytest-cov`.
68 68
69 In order to get an html report you can add `--cov-report=html` to the 69 In order to get an html report you can add `--cov-report=html` to the
70 pytest-command in tox.ini. 70 pytest-command in tox.ini.
71 71
72 For more information please refer to the 72 For more information please refer to the
73 [coverage documentation](https://coverage.readthedocs.io/) 73 [coverage documentation](https://coverage.readthedocs.io/)
LEFTRIGHT

Powered by Google App Engine
This is Rietveld