Issue 5383 - Add tests for the Chrome and Firefox packagers

tests/metadata.chrome

Index: tests/metadata.chrome
diff --git a/tests/metadata.chrome b/tests/metadata.chrome
new file mode 100644
index 0000000000000000000000000000000000000000..e4967fb2e0c463023aa3ebc1c0f0781be18caef3
--- /dev/null
+++ b/tests/metadata.chrome
@@ -0,0 +1,47 @@
+[general]
+version = 1.2.3
+author = Eyeo GmbH

[Sebastian Noack, 2017/08/14 15:20:11]

"eyeo" is spelled lower-case. Alternativley, you might want to use an example
company name here, but if you use the real one, please spell it correctly at
least. Also consider updating the tests for the Edge packager.

[tlucas, 2017/09/06 09:04:52]

Done.

+basename = adblockpluschrome
+permissions = tabs
+  <all_urls>
+  contextMenus
+  webRequest
+  webRequestBlocking
+  webNavigation
+  storage
+  unlimitedStorage
+  notifications
+backgroundScripts = ext/common.js
+  ext/background.js
+  lib/compat.js
+  lib/publicSuffixList.js
+  lib/adblockplus.js
+  messageResponder.js
+  background.js
+testScripts = ../ext/common.js
+  ../ext/background.js
+  ../lib/compat.js

[Sebastian Noack, 2017/08/14 15:20:12]

Do we need all the files listed in "backgroundScripts" and "testScripts" to
cover all code paths? The purpose of an integration test like this is not to
duplicate the exact same scenario which we have in production, but to provide a
minimal example that covers as many scenarios as possible.

[tlucas, 2017/09/06 09:04:51]

Done.

+devtools = devtools.html
+options = options.html
+managedStorageSchema = managed-storage-schema.json
+

[Sebastian Noack, 2017/08/14 15:20:11]

We probably should also add a [contentScripts] section and test that the scripts
listed there are added to the build. It seems this is missing in the existing
tests for the Edge packager as well, hence should be added there as well.

[tlucas, 2017/09/06 09:04:51]

Done, but: packagerEdge does not handle a section "contentScripts"

[Sebastian Noack, 2017/09/06 18:00:00]

Not sure what you mean but there are definitely content scripts in the Adblock
Plus for Microsoft Edge builds. However, note that metadata.edge in
adblockpluschrome inherits most of its options from metadata.chrome:
https://hg.adblockplus.org/adblockpluschrome/file/a401d9555223/metadata.edge#l2

+[convert_js]
+lib/foo.js =
+  lib/a.js
+  lib/b.js
+lib/foo.js[module] = true
+lib/foo.js[injectinfomodule] = true
+lib/foo.js[autoload] = icons
+
+[mapping]
+logo_44.png = chrome/icons/abp-44.png
+foo/logo_50.png = chrome/icons/abp-50.png
+icons/logo_150.png = chrome/icons/abp-150.png
+
+[compat]
+chrome = 49.0
+opera = 36.0
+
+[import_locales]
+_trans/*/test.properties = name
+    name_devbuild