Issue 5383 - Add tests for the Chrome and Firefox packagers

packagerChrome.py

Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index d75203d17b9e63262e69f44e5112cfc729005d8d..bf6f5f962f3c75b270e25d2438856ff2ed095ff3 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -43,13 +43,9 @@ def processFile(path, data, params):
 
 
 def makeIcons(files, filenames):
-    try:
-        from PIL import Image
-    except ImportError:
-        import Image
     icons = {}
     for filename in filenames:
-        width, height = Image.open(StringIO(files[filename])).size
+        width, height = struct.unpack('>ii', files[filename][16:24])

[Sebastian Noack, 2017/09/13 19:18:29]

I wonder whether it would be worth to check for the magic number (i.e.
'\x89PNG\r\n\x1a\n'), in order to fail, in case it is not a PNG file?

[tlucas, 2017/09/14 09:39:53]

Do we strictly require the icons to be pngs? If yes it would make sense, if not
we might want to consider reintroducing Pillow / PIL.

[Sebastian Noack, 2017/09/14 16:51:59]

We only use PNG. But technically, some other formats are possible as well,
though it's not clear which (other than PNG) are supported across all browsers,
and PNG is preferable over the other formats supported by Chrome, anyway.

However, in case somebody would (accidentally) use an icon in another format,
"width" and "height" would be completely arbitrary here, and it might be better
to have the build fail instead in that case.

         if(width != height):
             print >>sys.stderr, 'Warning: %s size is %ix%i, icon should be square' % (filename, width, height)
         icons[width] = filename