Issue 5383 - Add tests for the Chrome and Firefox packagers

packagerChrome.py

Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index d75203d17b9e63262e69f44e5112cfc729005d8d..bb2f33d8808fc9d06f189007d0788991dd310b4e 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -43,13 +43,15 @@ def processFile(path, data, params):
 
 
 def makeIcons(files, filenames):
-    try:
-        from PIL import Image
-    except ImportError:
-        import Image
     icons = {}
     for filename in filenames:
-        width, height = Image.open(StringIO(files[filename])).size
+        try:
+            magic, width, height = struct.unpack_from('>8s8xii',
+                                                      files[filename])
+        except struct.error:
+            magic = None
+        if magic != '\x89PNG\r\n\x1a\n':
+            raise TypeError(filename + ' is no valid PNG.')

[Sebastian Noack, 2017/09/21 19:09:03]

The definition of TypeError doesn't seem to apply here:
https://docs.python.org/3/library/exceptions.html#TypeError

This would rather be a ValueError. But for consistency, I would just go with
Exception, which is what buildtools is raising in other scenarios like this.

[tlucas, 2017/09/22 09:02:18]

Done.

         if(width != height):
             print >>sys.stderr, 'Warning: %s size is %ix%i, icon should be square' % (filename, width, height)
         icons[width] = filename