Issue 5383 - Add tests for the Chrome and Firefox packagers

ensure_dependencies.py

Index: ensure_dependencies.py
diff --git a/ensure_dependencies.py b/ensure_dependencies.py
index b1aedfde38ef4a12145691aa313dd2635bf6b613..96cf73208ffba1e9ff7d47f888ede46bf571cf60 100755
--- a/ensure_dependencies.py
+++ b/ensure_dependencies.py
@@ -344,6 +344,9 @@ def resolve_deps(repodir, level=0, self_update=True, overrideroots=None, skipdep
     if overrideroots is not None:
         config['_root'] = overrideroots
 
+    # F823
+    vcs = None

[kzar, 2017/10/16 11:17:24]

What's the idea with this change? The vcs variable seems kind of confusing to me
now, I also wonder if we should set it to None inside the loop?

[tlucas, 2017/10/17 12:45:40]

The change below change this to be an F823 flake8 error, rather than the
previously already ignored F821. This doesn't apply anymore, reverted it.

+
     for dir, sources in sorted(config.iteritems()):
         if (dir.startswith('_') or
             skipdependencies.intersection([s[0] for s in sources if s[0]])):
@@ -414,13 +417,22 @@ if __name__ == '__main__':
     parser = argparse.ArgumentParser(description='Verify dependencies for a set of repositories, by default the repository of this script.')
     parser.add_argument('repos', metavar='repository', type=str, nargs='*', help='Repository path')
     parser.add_argument('-q', '--quiet', action='store_true', help='Suppress informational output')
+    parser.add_argument(
+        '--nodejs-only',
+        action='store_true',
+        help='Install Node.js production-only dependencies only'
+    )
     args = parser.parse_args()
 
     if args.quiet:
         logging.disable(logging.INFO)
 
-    repos = args.repos
-    if not len(repos):
-        repos = [os.path.dirname(__file__)]
-    for repo in repos:
-        resolve_deps(repo)
+    if args.nodejs_only:
+        vcs = get_repo_type('.')

[kzar, 2017/10/16 11:17:24]

I wonder why we're assigning vcs here, since we just pass it through to
resolve_npm_dependencies anyway?

Do you mean to set it in the top scope, but then override it in the function
scopes? That could violate the no_shadow ESLint rule for our JavaScript code at
least.

[tlucas, 2017/10/17 12:45:41]

This was merely meant to be temporary. Passing it directly to
resolve_npm_dependencies.

+        resolve_npm_dependencies('.', vcs)
+    else:
+        repos = args.repos
+        if not len(repos):
+            repos = [os.path.dirname(__file__)]
+        for repo in repos:
+            resolve_deps(repo)