Issue 5383 - Add tests for the Chrome and Firefox packagers

ensure_dependencies.py

Index: ensure_dependencies.py
diff --git a/ensure_dependencies.py b/ensure_dependencies.py
index 9c9a9ca83dc7efe936204802a8b344b0159174cc..9481a081edecf9eff309b221befa664366b9afbb 100755
--- a/ensure_dependencies.py
+++ b/ensure_dependencies.py
@@ -426,13 +426,21 @@ if __name__ == '__main__':
     parser = argparse.ArgumentParser(description='Verify dependencies for a set of repositories, by default the repository of this script.')
     parser.add_argument('repos', metavar='repository', type=str, nargs='*', help='Repository path')
     parser.add_argument('-q', '--quiet', action='store_true', help='Suppress informational output')

[tlucas, 2017/10/17 12:45:50]

The changes in this file are meant to enable tox to install webpack, in order to
verify the packaging.
I'm not too sure about this though - please let me know what you think!

[kzar, 2017/10/17 13:03:54]

Yea I know what you mean, alternative I suppose tox could just run npm directly
but I'm not sure which is better. This looks OK to me anyway, I guess sometimes
stuff like this is necessary for tests.

[Sebastian Noack, 2017/10/17 22:19:06]

Any particular reason, to not just call "npm install" directly in tox.ini?

[tlucas, 2017/10/18 11:23:05]

What i had in mind was to have the ensure_npm_dependencies branch in
ensure_dependencies covered - but i guess this would be overkill right now and
should be done later, when i enhance the overall testcoverage.

Calling 'npm install' explicitly now.

+    parser.add_argument(
+        '--nodejs-only',
+        action='store_true',
+        help='Install Node.js production-only dependencies only'
+    )
     args = parser.parse_args()
 
     if args.quiet:
         logging.disable(logging.INFO)
 
-    repos = args.repos
-    if not len(repos):
-        repos = [os.path.dirname(__file__)]
-    for repo in repos:
-        resolve_deps(repo)
+    if args.nodejs_only:
+        resolve_npm_dependencies('.', get_repo_type('.'))
+    else:
+        repos = args.repos
+        if not len(repos):
+            repos = [os.path.dirname(__file__)]
+        for repo in repos:
+            resolve_deps(repo)