Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)
Patch Set: Addressing Vasily's comments Created Oct. 22, 2017, 11:11 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « package.json ('k') | tests/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 475e19103284caf7485b1d7e95881a0aa74535af..f9776069e51b47fdbd4df0525eb92493c4449b50 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -8,7 +8,6 @@ import io
import json
import os
import re
-from StringIO import StringIO
import struct
import subprocess
import sys
@@ -45,13 +44,15 @@ def processFile(path, data, params):
def makeIcons(files, filenames):
- try:
- from PIL import Image
- except ImportError:
- import Image
icons = {}
for filename in filenames:
- width, height = Image.open(StringIO(files[filename])).size
+ try:
+ magic, width, height = struct.unpack_from('>8s8xii',
+ files[filename])
+ except struct.error:
+ magic = None
+ if magic != '\x89PNG\r\n\x1a\n':
+ raise Exception(filename + ' is no valid PNG.')
if(width != height):
print >>sys.stderr, 'Warning: %s size is %ix%i, icon should be square' % (filename, width, height)
icons[width] = filename
« no previous file with comments | « package.json ('k') | tests/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld