Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29501571: Noissue - Skip unless-domain if list is empty (Closed)

Created:
July 31, 2017, 12:34 p.m. by Manish Jethani
Modified:
Aug. 1, 2017, 7:02 a.m.
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/abp2blocklist
Visibility:
Public.

Description

Noissue - Skip unless-domain if list is empty Very often the unless-domain list is empty after changeset 67d43960a891. This creates an invalid rule.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/abp2blocklist.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
July 31, 2017, 12:34 p.m. (2017-07-31 12:34:48 UTC) #1
Manish Jethani
Patch Set 1 Very often the unless-domain list is empty after changeset 67d43960a891. This creates ...
July 31, 2017, 12:36 p.m. (2017-07-31 12:36:10 UTC) #2
kzar
July 31, 2017, 2:28 p.m. (2017-07-31 14:28:47 UTC) #3
LGTM, go ahead and push this.

Powered by Google App Engine
This is Rietveld