Unified Diff: src/JsEngine.cpp
Issue 29501574:
Noissue - Fix a constructor order warning (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created July 31, 2017, 12:38 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/JsEngine.cpp |
| =================================================================== |
| --- a/src/JsEngine.cpp |
| +++ b/src/JsEngine.cpp |
| @@ -153,18 +153,18 @@ |
| timerParams.erase(timerParams.begin()); // remove timeout param |
| callback.Call(timerParams); |
| } |
| AdblockPlus::JsEngine::JsEngine(TimerPtr timer, FileSystemPtr fileSystem, |
| WebRequestPtr webRequest, LogSystemPtr logSystem) |
| : fileSystem(std::move(fileSystem)) |
| , timer(std::move(timer)) |
| + , logSystem(std::move(logSystem)) |
| , webRequest(std::move(webRequest)) |
| - , logSystem(std::move(logSystem)) |
| { |
| } |
| AdblockPlus::JsEnginePtr AdblockPlus::JsEngine::New(const AppInfo& appInfo, |
| TimerPtr timer, FileSystemPtr fileSystem, WebRequestPtr webRequest, LogSystemPtr logSystem) |
| { |
| JsEnginePtr result(new JsEngine(timer ? std::move(timer) : CreateDefaultTimer(), |
| fileSystem ? std::move(fileSystem) : CreateDefaultFileSystem(::DummyScheduler), |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
