Issue 5459 - Add support to show a notification based on the number of ads blocked

test/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 19 matching lines @@
   // within the sandbox succeed even with data passed in from outside.
   let globals = Object.assign({Array, JSON},
     setupTimerAndXMLHttp.call(this), setupRandomResult.call(this));
 
   let sandboxedRequire = createSandbox({globals});
   (
     {Prefs} = sandboxedRequire("./stub-modules/prefs"),
     {Notification} = sandboxedRequire("../lib/notification")
   );
 
-  sandboxedRequire("./stub-modules/utils");

[Wladimir Palant, 2017/08/22 07:54:58]

This change seems unnecessary?

[wspee, 2017/08/23 10:12:20]

Acknowledged.

-
   callback();
 };
 
 function showNotifications(url)
 {
   let shownNotifications = [];
   function showListener(notification)
   {
     shownNotifications.push(notification);
     Notification.markAsShown(notification.id);
@@ skipping 82 matching lines @@
     message: {"en-US": "Information"}
   };
 
   registerHandler.call(this, [information]);
   this.runScheduledTasks(1).then(() =>
   {
     test.deepEqual(showNotifications(), [information], "The notification is shown");
     test.deepEqual(showNotifications(), [], "Notification is treated as type information");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
+
+function testTargetSelectionFunc(propName, value, result)
+{
+  return function(test)
+  {
+    let targetInfo = {};
+    targetInfo[propName] = value;
+
+    let information = {
+      id: 1,
+      type: "information",
+      message: {"en-US": "Information"},
+      targets: [targetInfo]
+    };
+
+    registerHandler.call(this, [information]);
+    this.runScheduledTasks(1).then(() =>
+    {
+      let expected = (result ? [information] : []);
+      test.deepEqual(showNotifications(), expected, "Selected notification for " + JSON.stringify(information.targets));
+      test.deepEqual(showNotifications(), [], "No notification on second call");
+    }).catch(unexpectedError.bind(test)).then(() => test.done());
+  };
+}
 
 exports.testTargetSelection = {};
 
 for (let [propName, value, result] of [
   ["extension", "adblockpluschrome", true],
   ["extension", "adblockplus", false],
   ["extension", "adblockpluschrome2", false],
   ["extensionMinVersion", "1.4", true],
   ["extensionMinVersion", "1.4.1", true],
   ["extensionMinVersion", "1.5", false],
@@ skipping 26 matching lines @@
   ["blockedTotalMin", "11", false],
   ["blockedTotalMin", "10", true],
   ["blockedTotalMax", "10", true],
   ["blockedTotalMax", "1", false],
   ["locales", ["en-US"], true],
   ["locales", ["en-US", "de-DE"], true],
   ["locales", ["de-DE"], false],
   ["locales", ["en-GB", "de-DE"], false]
 ])
 {
-  exports.testTargetSelection[`${propName}=${value}`] = function(test)
-  {
-    let targetInfo = {};
-    targetInfo[propName] = value;
-
-    let information = {
-      id: 1,
-      type: "information",
-      message: {"en-US": "Information"},
-      targets: [targetInfo]
-    };
-
-    registerHandler.call(this, [information]);
-    this.runScheduledTasks(1).then(() =>
-    {
-      let expected = (result ? [information] : []);
-      test.deepEqual(showNotifications(), expected, "Selected notification for " + JSON.stringify(information.targets));
-      test.deepEqual(showNotifications(), [], "No notification on second call");
-    }).catch(unexpectedError.bind(test)).then(() => test.done());
-  };
+  exports.testTargetSelection[`${propName}=${value}`] = testTargetSelectionFunc(propName, value, result);
+}
+
+exports.testTargetSelectionNoShowStats = {
+
+  setUp(callback)
+  {
+    this.show_statsinpopup_orig = Prefs.show_statsinpopup;
+    Prefs.show_statsinpopup = false;
+    callback();
+  },
+  tearDown(callback)
+  {
+    Prefs.show_statsinpopup = this.show_statsinpopup_orig;
+    callback();
+  }
+};
+for (let [propName, value, result] of [
+  ["blockedTotalMin", "10", false],
+  ["blockedTotalMax", "10", false]
+])
+{
+  exports.testTargetSelectionNoShowStats[`${propName}=${value}`] = testTargetSelectionFunc(propName, value, result);
 }
 
 exports.testMultipleTargets = {};
 
 for (let [[propName1, value1, result1], [propName2, value2, result2]] of pairs([
   ["extension", "adblockpluschrome", true],
   ["extension", "adblockplus", false],
   ["extensionMinVersion", "1.4", true],
   ["extensionMinVersion", "1.5", false],
   ["application", "chrome", true],
@@ skipping 306 matching lines @@
   test.done();
 };
 
 exports.testMissingTranslation = function(test)
 {
   let notification = {message: {"en-US": "en-US"}};
   let texts = Notification.getLocalizedTexts(notification, "fr");
   test.equal(texts.message, "en-US");
   test.done();
 };