Issue 5482 - Sidebar and about ABP dialog

skin/new-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2017 eyeo GmbH
+ * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 17 matching lines @@
   src: url(fonts/SourceSansPro-Regular.woff);
   /* local("Ø") forces using no local font called Source Sans Pro */
   src: local("Ø"), url(fonts/SourceSansPro-Regular.woff) format("woff");
   font-weight: 400;
   font-style: normal;
 }
 
 @font-face
 {
   font-family: "Source Sans Pro";
-  src: url(fonts/SourceSansPro-Semibold.woff);
+  src: url(fonts/SourceSansPro-bold.woff);
   /* local("Ø") forces using no local font called Source Sans Pro */
-  src: local("Ø"), url(fonts/SourceSansPro-Semibold.woff) format("woff");
-  font-weight: 600;
+  src: local("Ø"), url(fonts/SourceSansPro-bold.woff) format("woff");
+  font-weight: 700;
   font-style: normal;
 }
 
 html
 {
   font-size: 20px;
 }
 
 body
 {
   background-color: #F5F5F5;
   display: flex;
   margin: 1.2rem 0.3rem;
   font-family: "Source Sans Pro", sans-serif;
   font-weight: 300;
   font-size: 1rem;

[saroyanm, 2017/08/23 13:35:46]

I started to use REMs because to avoide compounding problems and browser support
is not an issue here.

[juliandoucette, 2017/08/23 18:11:08]

Yes, but you set the font-size on the html element which overrides the browsers
font-size property and makes this change inaccessible. I suggest that you unset
the font-size on the HTML element and re-calculate REM values accordingly if you
choose to use REMs.

[juliandoucette, 2017/08/28 11:16:41]

NIT: This is still an issue.

[saroyanm, 2017/08/28 11:39:43]

Yes it is, this was discussed multiple times. 

This will require design change as well.

   color: #494949;
 }
 
 h1
 {
   font-size: 3rem;
   font-weight: 300;
 }
 
 h2
 {
   font-size: 1.375rem;
-  font-weight: 600;
+  font-weight: 700;
 }
 
 p
 {
   font-weight: 300;
 }
 
 [aria-hidden="true"]
 {
   display: none !important;
@@ skipping 10 matching lines @@
 
 /*
   Buttons and links
  */
 
 button,
 .button
 {
   padding: 0.8rem 1.2rem;
   font-size: 1.125rem;
-  font-weight: 600;
+  font-weight: 700;
   text-decoration: none;
   text-transform: uppercase;
   cursor: pointer;
 }
 
 button.primary,
 .button.primary
 {
   border: 0px;
   color: #FFF;
@@ skipping 14 matching lines @@
 button.secondary,
 .button.secondary
 {
   border: 1px solid #0A9DD1;
   color: #099CD0;
 }
 
 button.secondary:hover,
 .button.secondary:hover
 {
-  box-shadow: inset 0 0 0 1px #099CD0;
+  box-shadow: inset 0 0 0 4px #099CD0;
 }
 
 button[role="checkbox"],
 #dialog-body .table button[role="checkbox"]
 {
   width: 18px;
   height: 18px;
   margin-top: 0px;
   -moz-margin-end: 20px;
   -webkit-margin-end: 20px;
@@ skipping 52 matching lines @@
 
 html[dir="rtl"] #sidebar header
 {
   margin-left: 2rem;
 }
 
 #sidebar header h1
 {
   margin: 0rem;
   font-size: 1.5rem;
+}
+
+#sidebar header h1 strong
+{
+  font-weight: 700;
 }
 
 #sidebar header p
 {
   margin: 0rem;
   font-size: 2.4rem;
 }
 
 html[dir="rtl"] #sidebar header
 {
@@ skipping 41 matching lines @@
 [role="tablist"] a[role="tab"]:focus
 {
   outline: none;
   text-shadow: 0px 0px 1px #888;
 }
 
 li a[role="tab"][aria-selected]
 {
   -moz-border-start-color: #CDCDCD;
   -webkit-border-start-color: #CDCDCD;
-  font-weight: 600;
+  font-weight: 700;
   background-color: #FFF;
 }
 
 #sidebar footer
 {
   bottom: 0px;
   position: absolute;
   width: 100%;
 }
 
@@ skipping 72 matching lines @@
 {
   padding-top: 0px;
   padding-bottom: 6px;
 }
 
   .table li.empty-placeholder
 {
   background-color: #F5F5F5;
 }
 
-.table li [data-single='visible'],
-.table li:first-child:nth-last-child(2) [data-single='hidden']
+.table li [data-single="visible"],
+.table li:first-of-type:last-of-type [data-single="hidden"]
 {
   display: none;
 }
 
-.table li:first-child:nth-last-child(2) [data-single='visible']
+.table li:first-of-type:last-of-type [data-single="visible"]
 {
   display: block;
 }
 
 .table label
 {
   vertical-align: top;
 }
 
 .table.cols
@@ skipping 21 matching lines @@
 
 .table button.delete:hover
 {
   background-position: -61px -51px;
 }
 
 .icon,
 button[role="checkbox"],
 #dialog-body .table button[role="checkbox"],
 .table button.delete,
-#content-help a::before,
 #dialog-close::before,
 #all-filter-lists-table .arrow,
 .context-menu .content a::before
 {
   background-image: url(options-sprite.png);
   display: inline-block;
 }
 
 .icon-add,
 .icon-update
@@ skipping 20 matching lines @@
   cursor: pointer;
 }
 
 #dialog-close::before
 {
   content: "";
   height: 12px;
   width: 12px;
 }
 
-#content-help a::before
+#dialog-body button::before
 {
   background-position: 0px -42px;
   content: "";
   cursor: pointer;
   height: 11px;
   vertical-align: middle;
   width: 7px;
   -moz-margin-end: 12px;
   -webkit-margin-end: 12px;
 }
@@ skipping 27 matching lines @@
   background: none;
   cursor: pointer;
 }
 
 .controls button span:not(.icon)
 {
   -moz-margin-start: 16px;
   -webkit-margin-start: 16px;
   color: #3A7BA6;
   vertical-align: top;
+}
+
+/* 
+  Used for translatable screen reader only conten.
+  e.g.: Use instead of aria-label to avoid complex attribute value translation
+*/
+.sr-only
+{
+  position: absolute;
+  overflow: hidden;
+  clip: rect(0, 0, 0, 0);
+  width: 1px;
+  height: 1px;
+  margin: -1px;
+  padding: 0px;
+  border: 0px;
 }
 
 /*
   General tab content
 */
 
 #blocking-languages-dialog-table
 {
   border-bottom: none;
 }
@@ skipping 63 matching lines @@
   Advanced tab content
 */
 
 #all-filter-lists-table li.show-message .last-update,
 #all-filter-lists-table li:not(.show-message) .message,
 #custom-filters:not([data-mode="empty"]) #empty-custom-filters,
 #custom-filters[data-mode="empty"] #custom-filters-raw,
 #custom-filters:not([data-mode="write"]) #custom-filters-raw-controls,
 #custom-filters:not([data-mode="read"]) #custom-filters-edit,
 .state span,
-#acceptable-ads:not(.show-dnt-notification) #no-dnt
+#acceptable-ads:not(.show-dnt-notification) #dnt
 {
   display: none;
 }
 
 #all-filter-lists-table
 {
   display: inline-block;
 }
 
 #all-filter-lists-table
@@ skipping 280 matching lines @@
 
 div[role="tooltip"] .notes p
 {
   font-weight: 300;
 }
 
 /*
   Help tab content
 */
 
-#content-help
-{
-  counter-reset: section;
-}
-
-#content-help h1::before
-{
-  counter-increment: section;
-  content: counter(section) ". ";
-}
-
-#content-help a
-{
-  color: #3A7BA6;
+html:not([lang="zh"]) #social-chinese,
+html[lang="zh"] #social-general
+{
+  display: none;
+}
+
+#social ul
+{
+  list-style: none;
+}
+
+#social ul li
+{
   display: inline-block;
-  text-decoration: none;
-  -moz-margin-end: 16px;
-  -webkit-margin-end: 16px;
-  vertical-align: top;
-}
-
-#content-help a::before
-{
-  -moz-margin-end: 6px;
-  -webkit-margin-end: 6px;
-}
-
-#share-general:lang(zh),
-#share-chinese:not(zh)
-{
-  display: none;
+}
+
+#social ul li a
+{
+  display: block;
+  text-align: center;
+}
+
+#social ul li a::before
+{
+  display: block;
+  margin: 0em auto;
+  width: 2.5rem;
+  height: 2.5rem;
+  content: "";
+  background-color: #099DD1;
+}
+
+#twitter::before
+{
+  -webkit-mask: url("social/twitter.svg");
+  mask: url("social/twitter.svg");
+}
+
+#facebook::before
+{
+  -webkit-mask: url("social/facebook.svg");
+  mask: url("social/facebook.svg");
+}
+
+#google-plus::before
+{
+  -webkit-mask: url("social/googleplus.svg");
+  mask: url("social/googleplus.svg");
 }
 
 /*
   Dialog
 */
 
 #dialog-background
 {
   display: none;
   position: fixed;
@@ skipping 106 matching lines @@
   margin-top: 10px;
   margin-bottom: 20px;
   word-wrap: break-word;
 }
 
 body:not([data-dialog="about"]) #dialog-title-about,
 body:not([data-dialog="about"]) #dialog-content-about,
 body:not([data-dialog="custom"]) #dialog-title-custom,
 body:not([data-dialog="custom"]) #dialog-content-custom,
 body:not([data-dialog="language-add"]) #dialog-title-language-add,
-body:not([data-dialog="language-add"]) #dialog-content-language-add,
 body:not([data-dialog="language-change"]) #dialog-title-language-change,
-body:not([data-dialog="language-change"]) #dialog-content-language-change,
+body:not([data-dialog="language-add"]):not([data-dialog="language-change"]) #dialog-content-language-add,
+body:not([data-dialog="language-add"]) #dialog-body button.add,
+body:not([data-dialog="language-change"]) #dialog-body button.change,
 body:not([data-dialog="predefined"]) #dialog-title-predefined,
 body:not([data-dialog="predefined"]) #dialog-content-predefined,
 body:not([data-dialog]) #dialog
 {
   display: none;
 }
+
+/*
+  Notification
+*/
+
+#notification
+{
+  position: fixed;
+  top: 0rem;
+  left: 0rem;
+  display: flex;
+  padding: 1rem 1.9rem;
+  width: 100%;
+  box-sizing: border-box;
+  opacity: 0.8;
+  font-size: 1rem;
+  color: #099CD0;
+  background-color: #E1F2FA;
+}
+
+#notification strong
+{
+  flex: 1;
+  text-align: center;
+}
+
+#hide-notification
+{
+  border: 0rem;
+  padding: 0rem;
+  margin: 0rem 1rem;
+  background-color: transparent;
+  cursor: pointer;
+}
+
+#hide-notification::after
+{
+  content: "";
+  display: block;
+  height: 1rem;
+  width: 1rem;
+  border: 0rem;
+  background-color: #099DD1;
+  -webkit-mask: url(delete.svg);
+  mask: url(delete.svg);
+}
+
+#hide-notification:hover::after
+{
+  background-color: #5CBCE1;
+}