Unified Diff: new-options.html
Issue 29502647:
Issue 5482 - Sidebar and about ABP dialog (Closed)
Patch Set:
Created Aug. 9, 2017, 11:02 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.html |
| =================================================================== |
| --- a/new-options.html |
| +++ b/new-options.html |
| @@ -30,15 +30,16 @@ |
| </head> |
| <body data-tab="general"> |
| <!-- Navigation sidebar --> |
| - <div id="nav-sidebar"> |
| - <div id="fixed-sidebar" class="fixed"> |
| - <header id="page-title"> |
| - <p class="i18n_options_page_header_1"></p> |
| - <h1 class="i18n_options_page_header_2"></h1> |
| + <div id="sidebar"> |
| + <div class="fixed"> |
| + <header> |
| + <img id="sidebar-logo" src="skin/abp-logo.svg"> |
| + <h1 class="i18n_options_page_title_1"></h1> |
| + <p class="i18n_options_page_title_2"></p> |
|
juliandoucette
2017/08/16 23:42:31
NIT: ~"Settings" is not a paragraph. I suggest usi
saroyanm
2017/08/18 10:23:12
I agree.
saroyanm
2017/08/18 12:44:27
I tried that solution, but the markup and implemen
juliandoucette
2017/08/21 13:06:39
Acknowledged.
I think <p> is better than <h2> her
|
| </header> |
| <nav> |
| - <ul id="nav-tablist" class="tabs vertical" |
| + <ul class="tabs" |
| role="tablist" data-action="switch-tab" |
| data-keys="ArrowLeft ArrowUp ArrowRight ArrowDown"> |
| <li id="tab-general" role="tab" data-tab="general" |
| @@ -61,23 +62,15 @@ |
| </li> |
| </ul> |
| </nav> |
| - |
| - <a id="link-version"> |
| - <span class="i18n_options_version"></span> |
| - <span id="abp-version"></span> |
| - </a> |
| - |
| <footer> |
| - <ul class="tabs vertical bottom" data-action="open-doclink" |
| - data-keys="Enter"> |
| - <li id="tab-share" data-doclink="share-general" tabindex="0"> |
| - <span class="i18n_options_tab_share"></span> |
| - </li> |
| - <li id="tab-contribute" data-doclink="contribute" tabindex="0"> |
| - <span class="i18n_options_tab_contribute"></span> |
| - </li> |
| - </ul> |
| - </footer> |
| + <p> |
| + <a id="contribute" class="i18n_options_footer_contribute button secondary" |
|
juliandoucette
2017/08/16 23:42:31
I think we should add an external link icon to thi
saroyanm
2017/08/18 10:49:29
Right, but as mentioned in several places in curre
juliandoucette
2017/08/18 11:17:04
Acknowledged.
|
| + target="_blank"></a> |
| + </p> |
| + <p> |
| + <button id="about" class="i18n_options_footer_about" data-action="open-dialog" data-dialog="about"></button> |
|
juliandoucette
2017/08/16 23:42:31
I think that this link is very misleading. It look
saroyanm
2017/08/18 10:49:29
Same as above.
juliandoucette
2017/08/18 11:17:04
Acknowledged.
|
| + </p> |
| + </footer> |
| </div> |
| </div> |
| <div id="content"> |
| @@ -328,6 +321,7 @@ |
| <div id="dialog" role="dialog" aria-hidden="true"> |
| <header> |
| <span id="dialog-title"> |
| + <span id="dialog-title-about" class="i18n_options_dialog_about_title"></span> |
| <span id="dialog-title-custom" class="i18n_options_dialog_custom_title"></span> |
| <span id="dialog-title-language-add" class="i18n_options_dialog_language_title"></span> |
| <span id="dialog-title-language-change" class="i18n_options_dialog_language_title"></span> |
| @@ -336,6 +330,14 @@ |
| <button id="dialog-close" class="i18n_options_close focus-first" data-action="close-dialog"></button> |
| </header> |
| <div id="dialog-body" class="content"> |
| + <!-- About Adblock Plus --> |
| + <div id="dialog-content-about" class="dialog-content"> |
|
saroyanm
2017/08/10 12:04:48
Styles for Dialog is missing, I'll create separate
juliandoucette
2017/08/16 23:42:31
Acknowledged.
|
| + <p id="abp-version"></p> |
| + <p class="i18n_options_dialog_about_copyright"></p> |
| + <p> |
| + <button class="i18n_options_close primary" data-action="close-dialog"></button> |
|
saroyanm
2017/08/10 12:04:48
I'll update all other buttons to primary or second
juliandoucette
2017/08/16 23:42:31
Acknowledged.
|
| + </p> |
| + </div> |
| <!-- Add language subscription --> |
| <div id="dialog-content-language-add" class="dialog-content"> |
| <ul id="all-lang-table-add" class="table list"> |
« no previous file with comments
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
