modules/adblockplus/templates/mimeo.service.erb - Issue 29504594: #2687 - Include mimeo python module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/adblockplus/templates/mimeo.service.erb

Issue 29504594: #2687 - Include mimeo python module (Closed)

Left Patch Set: For comment 11 Created Aug. 8, 2017, 2:48 a.m.

Right Patch Set: For comments 47 and 48 Created Aug. 22, 2017, 8:33 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [Unit]	1 [Unit]

2 Description=Service that handles formating and parsing of logs	2 Description=Registers infromation received by an http/s petition.

3	3

4 [Service]	4 [Service]

5 ExecStart=/usr/bin/python3 /opt/mimeo/mimeo.py --response=<%= @response %> --log _format=<%= @format %> --port=<%= @port%> <%= @log_file %>	5 ExecStart=/usr/local/bin/mimeo.py '--response=<%= @response %>' '--format=<%= @f ormat %>' '--port=<%= @port %>' /var/adblockplus/mimeo/data
mathias 2017/08/08 07:51:46 This looks really prone to error due to configurat This looks really prone to error due to configuration values that are not aware of the implementation detail that is the lack of quotation here. According to https://github.com/systemd/systemd/issues/624 one can put quotes around the entire argument to avoid the quirky white-space escaping (like you did the accompanying YAML file). Also if you would use separate arguments for option and value, i.e. `--response "example"`, it should be possible to generate the latter via `<%= @response.to_s.to_json %>` -- including the proper quotes and escaping. f.lopez 2017/08/09 19:50:48 Jesus, I did look for something like this and was Show quoted text On 2017/08/08 07:51:46, mathias wrote: > This looks really prone to error due to configuration values that are not aware > of the implementation detail that is the lack of quotation here. According to > https://github.com/systemd/systemd/issues/624 one can put quotes around the > entire argument to avoid the quirky white-space escaping (like you did the > accompanying YAML file). Also if you would use separate arguments for option and > value, i.e. `--response "example"`, it should be possible to generate the latter > via `<%= @response.to_s.to_json %>` -- including the proper quotes and escaping. Jesus, I did look for something like this and was disappointed cause I didn't find anything, thanks!
6	6

7 [Install]	7 [Install]

8 WantedBy=multi-user.target	8 WantedBy=multi-user.target

9	9

LEFT	RIGHT